The patch titled Subject: zram: extend comp_algorithm attr write handling has been added to the -mm mm-unstable branch. Its filename is zram-extend-comp_algorithm-attr-write-handling.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-extend-comp_algorithm-attr-write-handling.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> Subject: zram: extend comp_algorithm attr write handling Date: Wed, 15 May 2024 16:12:48 +0900 Previously comp_algorithm device attr would accept only algorithm name param, however in order to enabled comp configuration we need to extend comp_algorithm_store() with param=value support. Link: https://lkml.kernel.org/r/20240515071645.1788128-12-senozhatsky@xxxxxxxxxxxx Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> Cc: Minchan Kim <minchan@xxxxxxxxxx> Cc: Nick Terrell <terrelln@xxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/block/zram/zram_drv.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) --- a/drivers/block/zram/zram_drv.c~zram-extend-comp_algorithm-attr-write-handling +++ a/drivers/block/zram/zram_drv.c @@ -1013,9 +1013,33 @@ static ssize_t comp_algorithm_store(stru size_t len) { struct zram *zram = dev_to_zram(dev); + char *args, *param, *val; + char *alg = NULL; int ret; - ret = __comp_algorithm_store(zram, ZRAM_PRIMARY_COMP, buf); + args = skip_spaces(buf); + while (*args) { + args = next_arg(args, ¶m, &val); + + /* + * We need to support 'param' without value, which is an + * old format for this attr (algorithm name only). + */ + if (!val || !*val) { + alg = param; + continue; + } + + if (!strcmp(param, "algo")) { + alg = val; + continue; + } + } + + if (!alg) + return -EINVAL; + + ret = __comp_algorithm_store(zram, ZRAM_PRIMARY_COMP, alg); return ret ? ret : len; } _ Patches currently in -mm which might be from senozhatsky@xxxxxxxxxxxx are zram-move-from-crypto-api-to-custom-comp-backends-api.patch zram-add-lzo-and-lzorle-compression-backends-support.patch zram-add-lz4-compression-backend-support.patch zram-add-lz4hc-compression-backend-support.patch zram-add-zstd-compression-backend-support.patch zram-pass-estimated-src-size-hint-to-zstd.patch zram-add-zlib-compression-backend-support.patch zram-add-842-compression-backend-support.patch zram-check-that-backends-array-has-at-least-one-backend.patch zram-introduce-zcomp_config-structure.patch zram-extend-comp_algorithm-attr-write-handling.patch zram-support-compression-level-comp-config.patch zram-add-support-for-dict-comp-config.patch lib-zstd-export-api-needed-for-dictionary-support.patch zram-add-dictionary-support-to-zstd-backend.patch zram-add-config-init-release-backend-callbacks.patch zram-share-dictionaries-between-per-cpu-contexts.patch zram-add-dictionary-support-to-lz4.patch lib-lz4hc-export-lz4_resetstreamhc-symbol.patch zram-add-dictionary-support-to-lz4hc.patch documentation-zram-add-documentation-for-algorithm-parameters.patch