Hi Andrew, > The quilt patch titled > Subject: s390/vmlogrdr: remove function pointer cast > has been removed from the -mm tree. Its filename was > s390-vmlogrdr-remove-function-pointer-cast.patch > > This patch was dropped because it was merged into the mm-nonmm-stable branch > of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > ------------------------------------------------------ > From: Nathan Chancellor <nathan@xxxxxxxxxx> > Subject: s390/vmlogrdr: remove function pointer cast > Date: Wed, 17 Apr 2024 11:24:35 -0700 > > Patch series "drivers/s390: Fix instances of -Wcast-function-type-strict". > > This series resolves the instances of -Wcast-function-type-strict that > show up in my s390 builds on -next, which has this warning enabled by > default. > > > This patch (of 3): > > Clang warns (or errors with CONFIG_WERROR) after enabling > -Wcast-function-type-strict by default: > > drivers/s390/char/vmlogrdr.c:746:18: error: cast from 'void (*)(const void *)' to 'void (*)(struct device *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict] > 746 | dev->release = (void (*)(struct device *))kfree; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > Add a standalone function to fix the warning properly, which addresses > the root of the warning that these casts are not safe for kCFI. The > comment is not really relevant after this change, so remove it. > > Link: https://lkml.kernel.org/r/20240417-s390-drivers-fix-cast-function-type-v1-0-fd048c9903b0@xxxxxxxxxx > Link: https://lkml.kernel.org/r/20240417-s390-drivers-fix-cast-function-type-v1-1-fd048c9903b0@xxxxxxxxxx > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx> > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Alexander Gordeev <agordeev@xxxxxxxxxxxxx> > Cc: Alexandra Winter <wintera@xxxxxxxxxxxxx> > Cc: Christian Borntraeger <borntraeger@xxxxxxxxxxxxx> > Cc: Heiko Carstens <hca@xxxxxxxxxxxxx> > Cc: Sven Schnelle <svens@xxxxxxxxxxxxx> > Cc: Thorsten Winkler <twinkler@xxxxxxxxxxxxx> > Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- Per this discussion [1] this patch should be dropped. This will be solved differently. [1] https://lore.kernel.org/all/20240418102549.6056-B-hca@xxxxxxxxxxxxx/
