The patch titled
Subject: mm: page_alloc: avoid defining unused function
has been added to the -mm mm-unstable branch. Its filename is
mm-page_alloc-consolidate-free-page-accounting-fix-4.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-page_alloc-consolidate-free-page-accounting-fix-4.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Subject: mm: page_alloc: avoid defining unused function
Date: Tue, 23 Apr 2024 19:14:43 +0300
In some configurations I got mm/page_alloc.c:656:20: warning: unused
function 'add_to_free_list' [-Wunused-function] Because the only user is
guarded with a certain ifdeffery, do the same for add_to_free_list().
Link: https://lkml.kernel.org/r/20240423161506.2637177-1-andriy.shevchenko@xxxxxxxxxxxxxxx
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Cc: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Cc: Vlastimil Babka <vbabka@xxxxxxx>
Cc: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/page_alloc.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
--- a/mm/page_alloc.c~mm-page_alloc-consolidate-free-page-accounting-fix-4
+++ a/mm/page_alloc.c
@@ -673,14 +673,6 @@ static inline void __add_to_free_list(st
area->nr_free++;
}
-static inline void add_to_free_list(struct page *page, struct zone *zone,
- unsigned int order, int migratetype,
- bool tail)
-{
- __add_to_free_list(page, zone, order, migratetype, tail);
- account_freepages(zone, 1 << order, migratetype);
-}
-
/*
* Used for pages which are on another list. Move the pages to the tail
* of the list - so the moved pages won't immediately be considered for
@@ -6770,6 +6762,14 @@ bool is_free_buddy_page(struct page *pag
EXPORT_SYMBOL(is_free_buddy_page);
#ifdef CONFIG_MEMORY_FAILURE
+static inline void add_to_free_list(struct page *page, struct zone *zone,
+ unsigned int order, int migratetype,
+ bool tail)
+{
+ __add_to_free_list(page, zone, order, migratetype, tail);
+ account_freepages(zone, 1 << order, migratetype);
+}
+
/*
* Break down a higher-order page in sub-pages, and keep our target out of
* buddy allocator.
_
Patches currently in -mm which might be from andriy.shevchenko@xxxxxxxxxxxxxxx are
mm-page_alloc-consolidate-free-page-accounting-fix-4.patch
devres-switch-to-use-dev_err_probe-for-unification.patch
devres-dont-use-proxy-headers.patch
