The patch titled
Subject: s390/smsgiucv_app: remove function pointer cast
has been added to the -mm mm-nonmm-unstable branch. Its filename is
s390-smsgiucv_app-remove-function-pointer-cast.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/s390-smsgiucv_app-remove-function-pointer-cast.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Nathan Chancellor <nathan@xxxxxxxxxx>
Subject: s390/smsgiucv_app: remove function pointer cast
Date: Wed, 17 Apr 2024 11:24:36 -0700
Clang warns (or errors with CONFIG_WERROR) after enabling
-Wcast-function-type-strict by default:
drivers/s390/net/smsgiucv_app.c:176:26: error: cast from 'void (*)(const void *)' to 'void (*)(struct device *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
176 | smsg_app_dev->release = (void (*)(struct device *)) kfree;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Add a standalone function to fix the warning properly, which addresses
the root of the warning that these casts are not safe for kCFI.
Link: https://lkml.kernel.org/r/20240417-s390-drivers-fix-cast-function-type-v1-2-fd048c9903b0@xxxxxxxxxx
Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
Cc: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>
Cc: Alexandra Winter <wintera@xxxxxxxxxxxxx>
Cc: Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>
Cc: Heiko Carstens <hca@xxxxxxxxxxxxx>
Cc: Sven Schnelle <svens@xxxxxxxxxxxxx>
Cc: Thorsten Winkler <twinkler@xxxxxxxxxxxxx>
Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/s390/net/smsgiucv_app.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--- a/drivers/s390/net/smsgiucv_app.c~s390-smsgiucv_app-remove-function-pointer-cast
+++ a/drivers/s390/net/smsgiucv_app.c
@@ -64,6 +64,11 @@ static void smsg_app_event_free(struct s
kfree(ev);
}
+static void smsg_app_free_dev(struct device *dev)
+{
+ kfree(dev);
+}
+
static struct smsg_app_event *smsg_app_event_alloc(const char *from,
const char *msg)
{
@@ -173,7 +178,7 @@ static int __init smsgiucv_app_init(void
}
smsg_app_dev->bus = &iucv_bus;
smsg_app_dev->parent = iucv_root;
- smsg_app_dev->release = (void (*)(struct device *)) kfree;
+ smsg_app_dev->release = smsg_app_free_dev;
smsg_app_dev->driver = smsgiucv_drv;
rc = device_register(smsg_app_dev);
if (rc) {
_
Patches currently in -mm which might be from nathan@xxxxxxxxxx are
s390-vmlogrdr-remove-function-pointer-cast.patch
s390-smsgiucv_app-remove-function-pointer-cast.patch
s390-netiucv-remove-function-pointer-cast.patch
