On Thu, 4 Apr 2024 09:17:37 +0200 Vlastimil Babka <vbabka@xxxxxxx> wrote:
> > Commit 3ee34eabac2a ("lib/stackdepot: fix first entry having a 0-handle")
> > changed the meaning of the pool_index field to mean "the pool index plus
> > 1". This made the code accessing this field less self-documenting, as
> > well as causing debuggers such as drgn to not be able to easily remain
> > compatible with both old and new kernels, because they typically do that
> > by testing for presence of the new field. Because stackdepot is a
> > debugging tool, we should make sure that it is debugger friendly.
> > Therefore, give the field a different name to improve readability as well
> > as enabling debugger backwards compatibility.
>
> Can we please move this to mm-hotfixes-unstable otherwise 6.9 would become
> an odd release with the new semantics and old name so debuggers wouldnt't
> recognize the new semantics there.
Done, thanks. I added:
This is needed in 6.9, which would otherwise become an odd release with
the new semantics and old name so debuggers wouldn't recognize the new
semantics there.
Fixes: 3ee34eabac2a ("lib/stackdepot: fix first entry having a 0-handle")
