On Sun, 2024-03-24 at 11:40 +1300, Barry Song wrote:
> And include/video/trident.h
>
> #if TRIDENTFB_DEBUG
> #define debug(f, a...) printk("%s:" f, __func__ , ## a);
> #else
> #define debug(f, a...)
> #endif
btw: the debug cases here should likely be something like:
#if TRIDENTFB_DEBUG
#define debug(fmt, ...) \
printk(KERN_DEBUG "%s: " fmt, __func__, ##__VA_ARGS__)
#else
#define debug(fmt, ...) \
do { \
if (0) \
printk(KERN_DEBUG "%s: " fmt, __func__, ##__VA_ARGS__); \
} while (0)
#endif
to preserve format checking in the !TRIDENTFB_DEBUG case
or just use pr_debug and remove TRIDENTFB_DEBUG and rely
on DYNAMIC_DEBUG to do the same thing.
