[merged mm-nonmm-stable] assoc_array-fix-the-return-value-in-assoc_array_insert_mid_shortcut.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The quilt patch titled
     Subject: assoc_array: fix the return value in assoc_array_insert_mid_shortcut()
has been removed from the -mm tree.  Its filename was
     assoc_array-fix-the-return-value-in-assoc_array_insert_mid_shortcut.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Roman Smirnov <r.smirnov@xxxxxx>
Subject: assoc_array: fix the return value in assoc_array_insert_mid_shortcut()
Date: Thu, 7 Mar 2024 10:17:17 +0300

Returning the edit variable is redundant because it is dereferenced right
before it is returned.  It would be better to return true.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Link: https://lkml.kernel.org/r/20240307071717.5318-1-r.smirnov@xxxxxx
Signed-off-by: Roman Smirnov <r.smirnov@xxxxxx>
Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 lib/assoc_array.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/lib/assoc_array.c~assoc_array-fix-the-return-value-in-assoc_array_insert_mid_shortcut
+++ a/lib/assoc_array.c
@@ -938,7 +938,7 @@ static bool assoc_array_insert_mid_short
 		edit->leaf_p = &new_n0->slots[0];
 
 	pr_devel("<--%s() = ok [split shortcut]\n", __func__);
-	return edit;
+	return true;
 }
 
 /**
_

Patches currently in -mm which might be from r.smirnov@xxxxxx are






[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux