On Mon, Mar 04, 2024 at 11:17:22AM -0800, Andrew Morton wrote:
> On Mon, 04 Mar 2024 11:11:28 -0800 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > + if (idx > nr_pages) {
> > + if (loops-- > 0)
> > + goto again;
> > + printk("page does not match folio\n");
>
> We shouldn't use a bare printk(). I'll make it pr_warn(), but should
> we be using WARN() here to get a backtrace?
I'm wary of doing that. We're in dump_page(), so we might well be in
the middle of something else going wrong. A backtrace will cause more
confusion than good. pr_warn() is fine; matches
pr_warn("page dumped because: %s\n", reason);
