Re: + lib-group_cpus-rework-group_cpus_evenly.patch added to mm-nonmm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 17 Jan 2024 08:45:18 -0800 Breno Leitao <leitao@xxxxxxxxxx> wrote:

> Hello Yury,
> 
> On Wed, Jan 10, 2024 at 10:15:59AM -0800, Yury Norov wrote:
> > diff --git a/lib/group_cpus.c b/lib/group_cpus.c
> > index 3a0db0f51f09..c9c95b21e6c6 100644
> > --- a/lib/group_cpus.c
> > +++ b/lib/group_cpus.c
> > @@ -353,8 +353,8 @@ struct cpumask *group_cpus_evenly(unsigned int numgrps)
> >  {
> >  	cpumask_var_t *node_to_cpumask __free(free_node_to_cpumask) = alloc_node_to_cpumask();
> >  	struct cpumask *masks __free(kfree) = kcalloc(numgrps, sizeof(*masks), GFP_KERNEL);
> > -	cpumask_var_t npresmsk __free(free_cpumask_var);
> > -	unsigned int curgrp, nr_present, nr_others;
> > +	cpumask_var_t npresmsk __free(free_cpumask_var) = NULL;
> 
> I am testing the akpm's mm-everything branch, and I am seeing this
> compilation error when compiling with clang.
> 
> 	lib/group_cpus.c: In function ‘group_cpus_evenly’:
> 	./include/linux/stddef.h:8:14: error: invalid initializer
> 	 #define NULL ((void *)0)
> 		      ^
> 	lib/group_cpus.c:356:52: note: in expansion of macro ‘NULL’
> 	  cpumask_var_t npresmsk __free(free_cpumask_var) = NULL;

yes, there have been a few reports of this.  I'll drop the series and
shall await the next revision, thanks.





[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux