The patch titled Subject: mips: suspend: include linux/suspend.h as needed has been added to the -mm mm-nonmm-unstable branch. Its filename is mips-suspend-include-linux-suspendh-as-needed.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mips-suspend-include-linux-suspendh-as-needed.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Arnd Bergmann <arnd@xxxxxxxx> Subject: mips: suspend: include linux/suspend.h as needed Date: Mon, 4 Dec 2023 12:57:07 +0100 A couple of functions are defined by the architecture and declared in linux/suspend.h, but mips is lacking the corresponding #include statement before the definition: arch/mips/power/cpu.c:16:6: warning: no previous prototype for 'save_processor_state' [-Wmissing-prototypes] arch/mips/power/cpu.c:26:6: warning: no previous prototype for 'restore_processor_state' [-Wmissing-prototypes] arch/mips/power/cpu.c:36:5: warning: no previous prototype for 'pfn_is_nosave' [-Wmissing-prototypes] arch/mips/power/hibernate.c:6:5: warning: no previous prototype for 'swsusp_arch_resume' [-Wmissing-prototypes] Link: https://lkml.kernel.org/r/20231204115710.2247097-18-arnd@xxxxxxxxxx Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxx> Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/mips/power/cpu.c | 1 + arch/mips/power/hibernate.c | 1 + 2 files changed, 2 insertions(+) --- a/arch/mips/power/cpu.c~mips-suspend-include-linux-suspendh-as-needed +++ a/arch/mips/power/cpu.c @@ -6,6 +6,7 @@ * Author: Hu Hongbing <huhb@xxxxxxxxxx> * Wu Zhangjin <wuzhangjin@xxxxxxxxx> */ +#include <linux/suspend.h> #include <asm/sections.h> #include <asm/fpu.h> #include <asm/dsp.h> --- a/arch/mips/power/hibernate.c~mips-suspend-include-linux-suspendh-as-needed +++ a/arch/mips/power/hibernate.c @@ -1,4 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 +#include <linux/suspend.h> #include <asm/tlbflush.h> extern int restore_image(void); _ Patches currently in -mm which might be from arnd@xxxxxxxx are kexec-fix-kexec_file-dependencies.patch kexec-fix-kexec_file-dependencies-fix.patch kexec-select-crypto-from-kexec_file-instead-of-depending-on-it.patch arch-turn-off-werror-for-architectures-with-known-warnings.patch mips-decompress-fix-add-missing-prototypes.patch mips-add-asm-syscallsh-header.patch mips-add-missing-declarations-for-trap-handlers.patch mips-rs870e-stop-exporting-local-functions.patch mips-signal-move-sigcontext-declarations-to-header.patch mips-mark-local-function-static-if-possible.patch mips-move-build_tlb_refill_handler-prototype.patch mips-move-jump_label_apply_nops-declaration-to-header.patch mips-unhide-uasm_in_compat_space_p-declaration.patch mips-fix-setup_zero_pages-prototype.patch mips-fix-tlb_init-prototype.patch mips-move-cache-declarations-into-header.patch mips-add-missing-declarations.patch mips-spram-fix-missing-prototype-warning-for-spram_config.patch mips-mt-include-asm-mips_mth.patch mips-remove-extraneous-asm-generic-iomaph-include.patch mips-suspend-include-linux-suspendh-as-needed.patch mips-hide-conditionally-unused-functions.patch mips-smp-fix-setup_profiling_timer-prototype.patch mips-kexec-include-linux-rebooth.patch ida-make-ida_dump-static.patch jffs2-mark-__jffs2_dbg_superblock_counts-static.patch sched-fair-move-unused-stub-functions-to-header.patch x86-sta2x11-include-header-for-sta2x11_get_instance-prototype.patch usb-fsl-mph-dr-of-mark-fsl_usb2_mpc5121_init-static.patch makefileextrawarn-turn-on-missing-prototypes-globally.patch