The patch titled Subject: mm/damon: document get_score_arg field of struct damos_quota has been added to the -mm mm-unstable branch. Its filename is mm-damon-core-implement-goal-oriented-feedback-driven-quota-auto-tuning-fix.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-damon-core-implement-goal-oriented-feedback-driven-quota-auto-tuning-fix.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: SeongJae Park <sj@xxxxxxxxxx> Subject: mm/damon: document get_score_arg field of struct damos_quota Date: Mon, 4 Dec 2023 17:01:06 +0000 Commit 99b36eab9c05 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning") on mm-unstable missed documenting 'get_score_arg' field of 'struct damos_quota' on the kernel-doc comment. Fix it. Link: https://lkml.kernel.org/r/20231204170106.60992-1-sj@xxxxxxxxxx Fixes: 99b36eab9c05 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning") on mm-unstable Signed-off-by: SeongJae Park <sj@xxxxxxxxxx> Cc: Brendan Higgins <brendanhiggins@xxxxxxxxxx> Cc: David Gow <davidgow@xxxxxxxxxx> Cc: Jonathan Corbet <corbet@xxxxxxx> Cc: Shuah Khan <shuah@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- include/linux/damon.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/include/linux/damon.h~mm-damon-core-implement-goal-oriented-feedback-driven-quota-auto-tuning-fix +++ a/include/linux/damon.h @@ -137,6 +137,7 @@ enum damos_action { * @weight_age: Weight of the region's age for prioritization. * * @get_score: Feedback function for self-tuning quota. + * @get_score_arg: Parameter for @get_score * * To avoid consuming too much CPU time or IO resources for applying the * &struct damos->action to large memory, DAMON allows users to set time and/or @@ -156,10 +157,10 @@ enum damos_action { * &weight_nr_accesses, and &weight_age, because monitoring operations are * encouraged to respect those. * - * If @get_score function pointer is set, DAMON calls it back and get the - * return value of it for every @reset_interval. Then, DAMON adjusts the - * effective quota using the return value as a feedback score to the current - * quota, using its internal feedback loop algorithm. + * If @get_score function pointer is set, DAMON calls it back with + * @get_score_arg and get the return value of it for every @reset_interval. + * Then, DAMON adjusts the effective quota using the return value as a feedback + * score to the current quota, using its internal feedback loop algorithm. * * The feedback loop algorithem assumes the quota input and the feedback score * output are in a positive proportional relationship, and the goal of the _ Patches currently in -mm which might be from sj@xxxxxxxxxx are mm-damon-core-copy-nr_accesses-when-splitting-region.patch mm-damon-sysfs-schemes-add-timeout-for-update_schemes_tried_regions.patch mm-damon-core-test-test-damon_split_region_ats-access-rate-copying.patch mm-damon-core-implement-goal-oriented-feedback-driven-quota-auto-tuning.patch mm-damon-core-implement-goal-oriented-feedback-driven-quota-auto-tuning-fix.patch mm-damon-sysfs-schemes-implement-files-for-scheme-quota-goals-setup.patch mm-damon-sysfs-schemes-commit-damos-quota-goals-user-input-to-damos.patch mm-damon-sysfs-schemes-implement-a-command-for-scheme-quota-goals-only-commit.patch mm-damon-core-test-add-a-unit-test-for-the-feedback-loop-algorithm.patch selftests-damon-test-quota-goals-directory.patch docs-mm-damon-design-document-damos-quota-auto-tuning.patch docs-abi-damon-document-damos-quota-goals.patch docs-admin-guide-mm-damon-usage-document-for-quota-goals.patch