The patch titled Subject: s390/traps: only define is_valid_bugaddr() under CONFIG_GENERIC_BUG has been added to the -mm mm-nonmm-unstable branch. Its filename is s390-traps-only-define-is_valid_bugaddr-under-config_generic_bug.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/s390-traps-only-define-is_valid_bugaddr-under-config_generic_bug.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Nathan Chancellor <nathan@xxxxxxxxxx> Subject: s390/traps: only define is_valid_bugaddr() under CONFIG_GENERIC_BUG Date: Thu, 30 Nov 2023 17:22:33 -0700 When building with -Wmissing-prototypes without CONFIG_GENERIC_BUG, there is a warning about a missing prototype for is_valid_bugaddr(): arch/s390/kernel/traps.c:46:5: warning: no previous prototype for 'is_valid_bugaddr' [-Wmissing-prototypes] 46 | int is_valid_bugaddr(unsigned long addr) | ^~~~~~~~~~~~~~~~ The prototype is only declared with CONFIG_GENERIC_BUG, so only define the function under the same condition to clear up the warning, which matches other architectures. Link: https://lkml.kernel.org/r/20231130-s390-missing-prototypes-v1-2-799d3cf07fb7@xxxxxxxxxx Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx> Cc: Alexander Gordeev <agordeev@xxxxxxxxxxxxx> Cc: Christian Borntraeger <borntraeger@xxxxxxxxxxxxx> Cc: Heiko Carstens <hca@xxxxxxxxxxxxx> Cc: Jan Höppner <hoeppner@xxxxxxxxxxxxx> Cc: Stefan Haberland <sth@xxxxxxxxxxxxx> Cc: Sven Schnelle <svens@xxxxxxxxxxxxx> Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx> Cc: Arnd Bergmann <arnd@xxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- arch/s390/kernel/traps.c | 2 ++ 1 file changed, 2 insertions(+) --- a/arch/s390/kernel/traps.c~s390-traps-only-define-is_valid_bugaddr-under-config_generic_bug +++ a/arch/s390/kernel/traps.c @@ -43,10 +43,12 @@ static inline void __user *get_trap_ip(s return (void __user *) (address - (regs->int_code >> 16)); } +#ifdef CONFIG_GENERIC_BUG int is_valid_bugaddr(unsigned long addr) { return 1; } +#endif void do_report_trap(struct pt_regs *regs, int si_signo, int si_code, char *str) { _ Patches currently in -mm which might be from nathan@xxxxxxxxxx are buffer-fix-grow_buffers-for-block-size-page_size-fix.patch hexagon-uaccess-remove-clear_user_hexagon.patch hexagon-mm-mark-paging_init-as-static.patch hexagon-mm-include-asm-setuph-for-setup_arch_memorys-prototype.patch hexagon-smp-mark-handle_ipi-and-start_secondary-as-static.patch hexagon-vm_fault-mark-do_page_fault-as-static.patch hexagon-vm_fault-include-asm-vm_faulth-for-prototypes.patch hexagon-vm_tlb-include-asm-tlbflushh-for-prototypes.patch hexagon-time-include-asm-timeh-for-prototypes.patch hexagon-time-mark-time_init_deferred-as-static.patch hexagon-time-include-asm-delayh-for-prototypes.patch hexagon-signal-switch-to-syscall_define0-for-sys_rt_sigreturn.patch hexagon-reset-include-linux-rebooth-for-prototypes.patch hexagon-process-include-linux-cpuh-for-arch_cpu_idle-prototype.patch hexagon-process-add-internal-prototype-for-do_work_pending.patch hexagon-vdso-include-asm-elfh-for-arch_setup_additional_pages-prototype.patch hexagon-vm_events-remove-unused-dummy_handler.patch hexagon-irq-add-prototype-for-arch_do_irq.patch hexagon-traps-remove-sys_syscall.patch hexagon-traps-add-internal-prototypes-for-functions-only-called-from-asm.patch s390-dasd-remove-dasd_stats_generic_show.patch s390-traps-only-define-is_valid_bugaddr-under-config_generic_bug.patch