The patch titled Subject: checkpatch: add judgment condition for Kconfig help test has been added to the -mm mm-nonmm-unstable branch. Its filename is checkpatch-add-judgment-condition-for-kconfig-help-test.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/checkpatch-add-judgment-condition-for-kconfig-help-test.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Cixi Geng <cixi.geng1@xxxxxxxxxx> Subject: checkpatch: add judgment condition for Kconfig help test Date: Thu, 16 Nov 2023 23:39:04 +0800 has_help only counts the situation in which the patch file adds a help line. If the config was renamed and the description was modified, has_help is zero because a "help" line was not added. here is one case: the modify file: drivers/iio/adc/Kconfig line(1047) -config SC27XX_ADC +config SPRD_ADC tristate "Spreadtrum SC27xx series PMICs ADC" depends on MFD_SC27XX_PMIC || COMPILE_TEST + depends on ARCH_SPRD help - Say yes here to build support for the integrated ADC inside the - Spreadtrum SC27xx series PMICs. + Say yes here to build support for the integrated ADC inside of the + Spreadtrum SC27xx and UMPxx series PMICs. This driver can also be built as a module. If so, the module will be called sc27xx_adc. the checkpatch result: WARNING: please write a help paragraph that fully describes the config symbol #23: FILE: drivers/iio/adc/Kconfig:1050: +config SPRD_ADC + tristate "Spreadtrum's ADC PMICs driver" depends on MFD_SC27XX_PMIC || COMPILE_TEST + depends on ARCH_SPRD help + Say yes here to build support for the integrated ADC inside of the + Say yes here to build support for the integrated ADC inside of the + Say yes here to build support for the integrated ADC inside of the + Spreadtrum SC27xx and UMPxx series PMICs. This driver can also be built as a module. If so, the module will be called sc27xx_adc. total: 0 errors, 1 warnings, 17 lines checked Link: https://lkml.kernel.org/r/20231116153904.15589-1-cixi.geng@xxxxxxxxx Fixes: b8709bce9089 ("checkpatch: improve Kconfig help test") Signed-off-by: Cixi Geng <cixi.geng1@xxxxxxxxxx> Cc: Dwaipayan Ray <dwaipayanray1@xxxxxxxxx> (reviewer:CHECKPATCH) Cc: Joe Perches <joe@xxxxxxxxxxx> Cc: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/scripts/checkpatch.pl~checkpatch-add-judgment-condition-for-kconfig-help-test +++ a/scripts/checkpatch.pl @@ -3616,7 +3616,7 @@ sub process { $needs_help = 1; next; } - if ($f =~ /^\+\s*help\s*$/) { + if ($f =~ /^\+\s*help\s*$/ || $f =~ /^\s*help\s*$/) { $has_help = 1; next; } _ Patches currently in -mm which might be from cixi.geng1@xxxxxxxxxx are checkpatch-add-judgment-condition-for-kconfig-help-test.patch