On Tue, Sep 12, 2023 at 09:09:38AM -0700, Andrew Morton wrote:
> On Tue, 12 Sep 2023 09:50:29 -0400 Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
>
> > > Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
> > > Cc: <stable@xxxxxxxxxxxxxxx>
> > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> >
> > This patch is superseded by the following patch you picked up:
> > mm-page_alloc-fix-cma-and-highatomic-landing-on-the-wrong-buddy-list.patch
>
> OK.
>
> > If you drop this patch here, you can also drop the fixlet to
> > free_unref_page(). The branch in there should look like this:
> >
> > if (pcp)
> > free_unref_page_commit(..., pcpmigratetype, ...);
> > else
> > free_one_page(..., migratetype, ...);
>
> Well kinda. It's actually
>
> if (pcp) {
> free_unref_page_commit(zone, pcp, page, migratetype, order);
^^ pcpmigratetype
is what I was trying to highlight.
But yes, the pcp_spin_unlock() is needed too!
> pcp_spin_unlock(pcp);
> } else {
> free_one_page(zone, page, pfn, order, migratetype, FPI_NONE);
> }
>
