The patch titled Subject: getrusage: use __for_each_thread() has been added to the -mm mm-nonmm-unstable branch. Its filename is getrusage-use-__for_each_thread.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/getrusage-use-__for_each_thread.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Oleg Nesterov <oleg@xxxxxxxxxx> Subject: getrusage: use __for_each_thread() Date: Sat, 9 Sep 2023 19:26:29 +0200 do/while_each_thread should be avoided when possible. Plus this change allows to avoid lock_task_sighand(), we can use rcu and/or sig->stats_lock instead. Link: https://lkml.kernel.org/r/20230909172629.GA20454@xxxxxxxxxx Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx> Cc: Eric W. Biederman <ebiederm@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/sys.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/kernel/sys.c~getrusage-use-__for_each_thread +++ a/kernel/sys.c @@ -1830,10 +1830,8 @@ void getrusage(struct task_struct *p, in r->ru_oublock += sig->oublock; if (maxrss < sig->maxrss) maxrss = sig->maxrss; - t = p; - do { + __for_each_thread(sig, t) accumulate_thread_rusage(t, r); - } while_each_thread(p, t); break; default: _ Patches currently in -mm which might be from oleg@xxxxxxxxxx are introduce-__next_thread-fix-next_tid-vs-exec-race.patch change-next_thread-to-use-__next_thread-group_leader.patch change-thread_group_empty-to-use-task_struct-thread_node.patch kill-task_struct-thread_group.patch __kill_pgrp_info-simplify-the-calculation-of-return-value.patch getrusage-add-the-signal_struct-sig-local-variable.patch getrusage-use-__for_each_thread.patch taskstats-fill_stats_for_tgid-use-for_each_thread.patch