On 8/22/23, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > On Tue, Aug 22, 2023 at 11:44:54AM -0700, Andrew Morton wrote: >> ------------------------------------------------------ >> From: Mateusz Guzik <mjguzik@xxxxxxxxx> >> Subject: maple_tree: shrink struct maple_tree from 24 to 16 bytes on LP64 >> Date: Tue, 22 Aug 2023 00:51:45 +0200 >> >> by plugging a padding hole. >> >> Link: >> https://lkml.kernel.org/r/20230821225145.2169848-1-mjguzik@xxxxxxxxx >> Signed-off-by: Mateusz Guzik <mjguzik@xxxxxxxxx> >> Reviewed-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx> >> Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx> >> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> --- > > Could we perhaps amend the commit log? > > Subject: maple_tree: Shrink struct maple_tree > > Pack the members of struct maple_tree to avoid holes on 64-bit. > The size shrinks from 24 to 16 bytes which will save eight bytes > in every structure which embeds it. > > Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> > Is this kind of descriptiveness expected? I am only a sojourner here, but even then I suspect I'm going to run into a bunch of other trivialities of this sort. fwiw I would avoid the term 'pack' as it suggests the attribute "packed", perhaps: > Reorder the members of struct maple_tree to avoid holes on 64-bit. > The size shrinks from 24 to 16 bytes which will save eight bytes > in every structure which embeds it. -- Mateusz Guzik <mjguzik gmail.com>
