The patch titled
Subject: mm: remove set_compound_page_dtor()
has been added to the -mm mm-unstable branch. Its filename is
mm-remove-set_compound_page_dtor.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-remove-set_compound_page_dtor.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Sidhartha Kumar <sidhartha.kumar@xxxxxxxxxx>
Subject: mm: remove set_compound_page_dtor()
Date: Mon, 12 Jun 2023 09:34:05 -0700
All users can use the folio equivalent so this function can be safely
removed.
Link: https://lkml.kernel.org/r/20230612163405.99345-1-sidhartha.kumar@xxxxxxxxxx
Signed-off-by: Sidhartha Kumar <sidhartha.kumar@xxxxxxxxxx>
Cc: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxx>
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Cc: Tarun Sahu <tsahu@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/mm.h | 10 ----------
mm/huge_memory.c | 2 +-
mm/internal.h | 2 +-
3 files changed, 2 insertions(+), 12 deletions(-)
--- a/include/linux/mm.h~mm-remove-set_compound_page_dtor
+++ a/include/linux/mm.h
@@ -1223,16 +1223,6 @@ enum compound_dtor_id {
};
extern compound_page_dtor * const compound_page_dtors[NR_COMPOUND_DTORS];
-static inline void set_compound_page_dtor(struct page *page,
- enum compound_dtor_id compound_dtor)
-{
- struct folio *folio = (struct folio *)page;
-
- VM_BUG_ON_PAGE(compound_dtor >= NR_COMPOUND_DTORS, page);
- VM_BUG_ON_PAGE(!PageHead(page), page);
- folio->_folio_dtor = compound_dtor;
-}
-
static inline void folio_set_compound_dtor(struct folio *folio,
enum compound_dtor_id compound_dtor)
{
--- a/mm/huge_memory.c~mm-remove-set_compound_page_dtor
+++ a/mm/huge_memory.c
@@ -583,7 +583,7 @@ void prep_transhuge_page(struct page *pa
VM_BUG_ON_FOLIO(folio_order(folio) < 2, folio);
INIT_LIST_HEAD(&folio->_deferred_list);
- set_compound_page_dtor(page, TRANSHUGE_PAGE_DTOR);
+ folio_set_compound_dtor(folio, TRANSHUGE_PAGE_DTOR);
}
static inline bool is_transparent_hugepage(struct page *page)
--- a/mm/internal.h~mm-remove-set_compound_page_dtor
+++ a/mm/internal.h
@@ -391,7 +391,7 @@ static inline void prep_compound_head(st
{
struct folio *folio = (struct folio *)page;
- set_compound_page_dtor(page, COMPOUND_PAGE_DTOR);
+ folio_set_compound_dtor(folio, COMPOUND_PAGE_DTOR);
set_compound_order(page, order);
atomic_set(&folio->_entire_mapcount, -1);
atomic_set(&folio->_nr_pages_mapped, 0);
_
Patches currently in -mm which might be from sidhartha.kumar@xxxxxxxxxx are
mm-remove-set_compound_page_dtor.patch
