+ maple_tree-add-mas_next_range-and-mas_find_range-interfaces-checkpatch-fixes.patch added to mm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: maple_tree-add-mas_next_range-and-mas_find_range-interfaces-checkpatch-fixes
has been added to the -mm mm-unstable branch.  Its filename is
     maple_tree-add-mas_next_range-and-mas_find_range-interfaces-checkpatch-fixes.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/maple_tree-add-mas_next_range-and-mas_find_range-interfaces-checkpatch-fixes.patch

This patch will later appear in the mm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: maple_tree-add-mas_next_range-and-mas_find_range-interfaces-checkpatch-fixes
Date: Fri May 12 03:59:53 PM PDT 2023

ERROR: Macros with complex values should be enclosed in parentheses
#58: FILE: include/linux/maple_tree.h:544:
+#define mas_contiguous(__mas, __entry, __max) \
+	while (((__entry) = mas_find_range((__mas), (__max))) != NULL)

WARNING: suspect code indent for conditional statements (8, 12)
#285: FILE: lib/maple_tree.c:6136:
+	if (mas_find_setup(mas, max, &entry))
+	    return entry;

WARNING: Statements should start on a tabstop
#286: FILE: lib/maple_tree.c:6137:
+	    return entry;

total: 1 errors, 2 warnings, 284 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/maple_tree-add-mas_next_range-and-mas_find_range-interfaces.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: "Liam R. Howlett" <Liam.Howlett@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 lib/maple_tree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/lib/maple_tree.c~maple_tree-add-mas_next_range-and-mas_find_range-interfaces-checkpatch-fixes
+++ a/lib/maple_tree.c
@@ -6134,7 +6134,7 @@ void *mas_find(struct ma_state *mas, uns
 	void *entry = NULL;
 
 	if (mas_find_setup(mas, max, &entry))
-	    return entry;
+		return entry;
 
 	/* Retries on dead nodes handled by mas_next_slot */
 	return mas_next_slot(mas, max, false);
_

Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are

mm-compaction-optimize-compact_memory-to-comply-with-the-admin-guide-fix.patch
maple_tree-add-mas_next_range-and-mas_find_range-interfaces-checkpatch-fixes.patch




[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux