On Fri, 5 May 2023 17:00:20 -0700 Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > On Fri, May 5, 2023 at 4:57 PM SeongJae Park <sj@xxxxxxxxxx> wrote: > > > > Hi Andrew, > > > > On Fri, 05 May 2023 15:45:21 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > The quilt patch titled > > > Subject: seq_buf: add seq_buf_do_printk() helper > > > has been removed from the -mm tree. Its filename was > > > seq_buf-add-seq_buf_do_printk-helper.patch > > > > > > This patch was dropped because it was merged into mainline or a subsystem tree > > > > Just for headup. I just found the latest mm-unstable indeed dropped the patch > > but a patch[1] depends on it. As a result, build fails as below. > > That patch was merged into Linus's tree, so I assumed that's why it > was dropped from mm-unstable. Perhaps I am wrong. Same to my assumption, and fit with the original mail's explanation. I confirmed the patch has merged in the mainline as commit 96928d9032a7. So this will be fixed if 1) mm-unstable is rebased on v6.4-rc1, 2) the dropped patch is added again on mm-unstable, or 3) the patch[1] currently triggering the failure is dropped. This is never an important issue for me, so I don't have any preference or opinion about the fix. I just wanted to save time for others who might got report of this. [1] https://lore.kernel.org/mm-commits/20230502201509.B8711C433D2@xxxxxxxxxxxxxxx/ Thanks, SJ > > > > > CC mm/memcontrol.o > > /mm/memcontrol.c: In function ‘mem_cgroup_print_oom_meminfo’: > > /mm/memcontrol.c:1693:2: error: implicit declaration of function ‘seq_buf_do_printk’; did you mean ‘seq_buf_bprintf’? [-Werror=implicit-function-declaration] > > 1693 | seq_buf_do_printk(&s, KERN_INFO); > > | ^~~~~~~~~~~~~~~~~ > > | seq_buf_bprintf > > cc1: some warnings being treated as errors > > > > [1] https://lore.kernel.org/mm-commits/20230502201509.B8711C433D2@xxxxxxxxxxxxxxx/ > > > > > > Thanks, > > SJ
