On 21/03/2023 22:29, Andrew Morton wrote: > The patch titled > Subject: checkpatch: add missing bindings license check > has been added to the -mm mm-nonmm-unstable branch. Its filename is > checkpatch-add-missing-bindings-license-check.patch > > This patch will shortly appear at > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/checkpatch-add-missing-bindings-license-check.patch > > This patch will later appear in the mm-nonmm-unstable branch at > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** > > The -mm tree is included into linux-next via the mm-everything > branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > and is updated there every 2-3 working days > > ------------------------------------------------------ > From: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> > Subject: checkpatch: add missing bindings license check > Date: Mon, 20 Mar 2023 23:33:50 +0300 > > All headers from 'include/dt-bindings/' must be verified by checkpatch > together with Documentation bindings, because all of them are part of the > whole DT bindings system. > > The requirement is dual licensed and matching pattern: > /GPL-2\.0(?:-only|-or-later|\+)? (?:OR|or) BSD-2-Clause/ > > The issue was found during patch review: > https://lore.kernel.org/all/20230313201259.19998-4-ddrokosov@xxxxxxxxxxxxxx/ > > Link: https://lkml.kernel.org/r/20230320203350.13696-1-ddrokosov@xxxxxxxxxxxxxx > Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> > Acked-by: Joe Perches <joe@xxxxxxxxxxx> > Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx> > Cc: Dwaipayan Ray <dwaipayanray1@xxxxxxxxx> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Cc: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Hi Andrew, Can you drop this patch? Rob raised few concerns and it should be reworked. Rob's arguments/comments: https://lore.kernel.org/all/20230321215337.GA1656483-robh@xxxxxxxxxx/ https://lore.kernel.org/all/CAL_Jsq+-YJsBO+LuPJ=ZQ=eb-monrwzuCppvReH+af7hYZzNaQ@xxxxxxxxxxxxxx/ https://lore.kernel.org/all/CAL_JsqJa-McFEorLr6ZWNqaEtjG8Oi2rNJ3hGwb2Xk3jvqMZgQ@xxxxxxxxxxxxxx/ Best regards, Krzysztof