+ notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes.patch added to mm-nonmm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes
has been added to the -mm mm-nonmm-unstable branch.  Its filename is
     notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes.patch

This patch will later appear in the mm-nonmm-unstable branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days

------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes
Date: Tue Mar 14 01:51:03 PM PDT 2023

ERROR: "(foo*)" should be "(foo *)"
#117: FILE: kernel/notifier.c:43:
+	trace_notifiers_register((void*)n->notifier_call);

ERROR: "(foo*)" should be "(foo *)"
#125: FILE: kernel/notifier.c:53:
+			trace_notifiers_unregister((void*)n->notifier_call);

ERROR: "(foo*)" should be "(foo *)"
#133: FILE: kernel/notifier.c:92:
+		trace_notifiers_run((void*)nb->notifier_call);

total: 3 errors, 0 warnings, 99 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/notifiers-add-tracepoints-to-the-notifiers-infrastructure.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: "Guilherme G. Piccoli" <gpiccoli@xxxxxxxxxx>
Cc: Guilherme G. Piccoli <kernel@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---


--- a/kernel/notifier.c~notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes
+++ a/kernel/notifier.c
@@ -40,7 +40,7 @@ static int notifier_chain_register(struc
 	}
 	n->next = *nl;
 	rcu_assign_pointer(*nl, n);
-	trace_notifiers_register((void*)n->notifier_call);
+	trace_notifiers_register((void *)n->notifier_call);
 	return 0;
 }
 
@@ -50,7 +50,7 @@ static int notifier_chain_unregister(str
 	while ((*nl) != NULL) {
 		if ((*nl) == n) {
 			rcu_assign_pointer(*nl, n->next);
-			trace_notifiers_unregister((void*)n->notifier_call);
+			trace_notifiers_unregister((void *)n->notifier_call);
 			return 0;
 		}
 		nl = &((*nl)->next);
@@ -89,7 +89,7 @@ static int notifier_call_chain(struct no
 			continue;
 		}
 #endif
-		trace_notifiers_run((void*)nb->notifier_call);
+		trace_notifiers_run((void *)nb->notifier_call);
 		ret = nb->notifier_call(nb, val, v);
 
 		if (nr_calls)
_

Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are

mm-page_alloc-reduce-page-alloc-free-sanity-checks-checkpatch-fixes.patch
mm-page_alloc-reduce-page-alloc-free-sanity-checks-fix.patch
mm-userfaultfd-support-wp-on-multiple-vmas-fix.patch
mm-add-new-api-to-enable-ksm-per-process-fix.patch
vmstat-add-pcp-remote-node-draining-via-cpu_vm_stats_fold-fix.patch
scripts-link-vmlinuxsh-fix-error-message-presentation.patch
notifiers-add-tracepoints-to-the-notifiers-infrastructure-checkpatch-fixes.patch




[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux