The patch titled
Subject: proc: remove mark_inode_dirty() in .setattr()
has been added to the -mm mm-nonmm-unstable branch. Its filename is
proc-remove-mark_inode_dirty-in-setattr.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/proc-remove-mark_inode_dirty-in-setattr.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Chao Yu <chao@xxxxxxxxxx>
Subject: proc: remove mark_inode_dirty() in .setattr()
Date: Tue, 31 Jan 2023 23:08:40 +0800
procfs' .setattr() has updated i_uid, i_gid and i_mode into proc dirent,
we don't need to call mark_inode_dirty() for delayed update, remove it.
Link: https://lkml.kernel.org/r/20230131150840.34726-1-chao@xxxxxxxxxx
Signed-off-by: Chao Yu <chao@xxxxxxxxxx>
Reviewed-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
diff --git a/fs/proc/base.c~proc-remove-mark_inode_dirty-in-setattr b/fs/proc/base.c
--- a/fs/proc/base.c~proc-remove-mark_inode_dirty-in-setattr
+++ b/fs/proc/base.c
@@ -700,7 +700,6 @@ int proc_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
return error;
setattr_copy(&nop_mnt_idmap, inode, attr);
- mark_inode_dirty(inode);
return 0;
}
diff --git a/fs/proc/generic.c~proc-remove-mark_inode_dirty-in-setattr b/fs/proc/generic.c
--- a/fs/proc/generic.c~proc-remove-mark_inode_dirty-in-setattr
+++ b/fs/proc/generic.c
@@ -127,7 +127,6 @@ static int proc_notify_change(struct mnt_idmap *idmap,
return error;
setattr_copy(&nop_mnt_idmap, inode, iattr);
- mark_inode_dirty(inode);
proc_set_user(de, inode->i_uid, inode->i_gid);
de->mode = inode->i_mode;
diff --git a/fs/proc/proc_sysctl.c~proc-remove-mark_inode_dirty-in-setattr b/fs/proc/proc_sysctl.c
--- a/fs/proc/proc_sysctl.c~proc-remove-mark_inode_dirty-in-setattr
+++ b/fs/proc/proc_sysctl.c
@@ -841,7 +841,6 @@ static int proc_sys_setattr(struct mnt_idmap *idmap,
return error;
setattr_copy(&nop_mnt_idmap, inode, attr);
- mark_inode_dirty(inode);
return 0;
}
_
Patches currently in -mm which might be from chao@xxxxxxxxxx are
proc-remove-mark_inode_dirty-in-setattr.patch
