On (23/02/03 16:51), Sergey Senozhatsky wrote: > > From: Christoph Hellwig <hch@xxxxxx> > > Subject: block: remove ->rw_page > > Date: Wed, 25 Jan 2023 14:34:36 +0100 > > > > The ->rw_page method is a special purpose bypass of the usual bio handling > > path that is limited to single-page reads and writes and synchronous which > > causes a lot of extra code in the drivers, callers and the block layer. > > > > The only remaining user is the MM swap code. Switch that swap code to > > simply submit a single-vec on-stack bio an synchronously wait on it based > > on a newly added QUEUE_FLAG_SYNCHRONOUS flag set by the drivers that > > currently implement ->rw_page instead. While this touches one extra cache > > line and executes extra code, it simplifies the block layer and drivers > > and ensures that all feastures are properly supported by all drivers, e.g. > > right now ->rw_page bypassed cgroup writeback entirely. > > > > [akpm@xxxxxxxxxxxxxxxxxxxx: fix comment typo, per Dan] > > Link: https://lkml.kernel.org/r/20230125133436.447864-8-hch@xxxxxx > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx> > > Cc: Dave Jiang <dave.jiang@xxxxxxxxx> > > Cc: Ira Weiny <ira.weiny@xxxxxxxxx> > > Cc: Jens Axboe <axboe@xxxxxxxxx> > > Cc: Keith Busch <kbusch@xxxxxxxxxx> > > Cc: Minchan Kim <minchan@xxxxxxxxxx> > > Cc: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> > > Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx> > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Appologies for fat finger. Was going to say Tested-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> # zram Revieewd-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx> # zram
