Re: + mm-use-stack_depot_early_init-for-kmemleak.patch added to mm-hotfixes-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19.1.2023. 15:51, Vlastimil Babka wrote:
On 1/19/23 15:40, Catalin Marinas wrote:
On Thu, Jan 19, 2023 at 02:02:29PM +0100, Mirsad Goran Todorovac wrote:
On 18.1.2023. 1:19, Andrew Morton wrote:
--- a/mm/kmemleak.c~mm-use-stack_depot_early_init-for-kmemleak
+++ a/mm/kmemleak.c
@@ -2070,8 +2070,10 @@ static int __init kmemleak_boot_config(c
   		return -EINVAL;
   	if (strcmp(str, "off") == 0)
   		kmemleak_disable();
-	else if (strcmp(str, "on") == 0)
+	else if (strcmp(str, "on") == 0) {
   		kmemleak_skip_disable = 1;
+		stack_depot_want_early_init();
+	}
   	else
   		return -EINVAL;
   	return 0;
_

Patches currently in -mm which might be from zhaoyang.huang@xxxxxxxxxx are

mm-use-stack_depot_early_init-for-kmemleak.patch

Please note that this patch activates stack_depot_want_early_init() only when
kernel boot param "kmemleak=on" is used.

When the following configuration is used:

CONFIG_HAVE_DEBUG_KMEMLEAK=y
CONFIG_DEBUG_KMEMLEAK=y
CONFIG_DEBUG_KMEMLEAK_MEM_POOL_SIZE=16000
# CONFIG_DEBUG_KMEMLEAK_TEST is not set
# CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF is not set
CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN=y

Indeed, I commented here already:

https://lore.kernel.org/all/Y8gDdnpvkCKvVV1t@xxxxxxx/

And v4 was submitted with that change included:

https://lore.kernel.org/all/1674091345-14799-2-git-send-email-zhaoyang.huang@xxxxxxxxxx/

Indeed! I was five hours off at least.

Sorry, I missed these emails because linux-kernel@xxxxxxxxxxxxxxx was not Cc:ed.
Fixed the filter now.

I agree this patch looks like it should be the solution, and I will test it in
the initial environment that triggered the bug as soon as I finish my current build.

Apologies, again.

Regards,
Mirsad

--
Mirsad Todorovac
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb
Republic of Croatia, the European Union
--
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu




[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux