The patch titled
Subject: fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions
has been added to the -mm mm-nonmm-unstable branch. Its filename is
fat-fix-return-value-of-vfat_bad_char-and-vfat_replace_char-functions.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/fat-fix-return-value-of-vfat_bad_char-and-vfat_replace_char-functions.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
Subject: fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions
Date: Mon, 26 Dec 2022 15:25:12 +0100
These functions returns boolean value not wide character.
Link: https://lkml.kernel.org/r/20221226142512.13848-1-pali@xxxxxxxxxx
Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/fat/namei_vfat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/fs/fat/namei_vfat.c~fat-fix-return-value-of-vfat_bad_char-and-vfat_replace_char-functions
+++ a/fs/fat/namei_vfat.c
@@ -200,7 +200,7 @@ static const struct dentry_operations vf
/* Characters that are undesirable in an MS-DOS file name */
-static inline wchar_t vfat_bad_char(wchar_t w)
+static inline bool vfat_bad_char(wchar_t w)
{
return (w < 0x0020)
|| (w == '*') || (w == '?') || (w == '<') || (w == '>')
@@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wcha
|| (w == '\\');
}
-static inline wchar_t vfat_replace_char(wchar_t w)
+static inline bool vfat_replace_char(wchar_t w)
{
return (w == '[') || (w == ']') || (w == ';') || (w == ',')
|| (w == '+') || (w == '=');
_
Patches currently in -mm which might be from pali@xxxxxxxxxx are
