The patch titled
Subject: mm-uffd-detect-pgtable-allocation-failures-checkpatch-fixes
has been added to the -mm mm-unstable branch. Its filename is
mm-uffd-detect-pgtable-allocation-failures-checkpatch-fixes.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-uffd-detect-pgtable-allocation-failures-checkpatch-fixes.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: mm-uffd-detect-pgtable-allocation-failures-checkpatch-fixes
Date: Wed Jan 4 05:54:55 PM PST 2023
WARNING: Statements should start on a tabstop
#127: FILE: mm/mprotect.c:353:
+ long err = 0; \
WARNING: Statements should start on a tabstop
#128: FILE: mm/mprotect.c:354:
+ if (unlikely(uffd_wp_protect_file(vma, cp_flags))) { \
WARNING: suspect code indent for conditional statements (18, 26)
#128: FILE: mm/mprotect.c:354:
+ if (unlikely(uffd_wp_protect_file(vma, cp_flags))) { \
+ low##_t *p = low##_alloc(vma->vm_mm, high, addr); \
ERROR: need consistent spacing around '*' (ctx:WxV)
#129: FILE: mm/mprotect.c:355:
+ low##_t *p = low##_alloc(vma->vm_mm, high, addr); \
^
WARNING: Statements should start on a tabstop
#130: FILE: mm/mprotect.c:356:
+ if (p == NULL) \
WARNING: suspect code indent for conditional statements (26, 34)
#130: FILE: mm/mprotect.c:356:
+ if (p == NULL) \
+ err = -ENOMEM; \
total: 1 errors, 5 warnings, 219 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
./patches/mm-uffd-detect-pgtable-allocation-failures.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Peter Xu <peterx@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/mprotect.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
--- a/mm/mprotect.c~mm-uffd-detect-pgtable-allocation-failures-checkpatch-fixes
+++ a/mm/mprotect.c
@@ -350,14 +350,14 @@ uffd_wp_protect_file(struct vm_area_stru
*/
#define change_prepare(vma, high, low, addr, cp_flags) \
({ \
- long err = 0; \
- if (unlikely(uffd_wp_protect_file(vma, cp_flags))) { \
- low##_t *p = low##_alloc(vma->vm_mm, high, addr); \
- if (p == NULL) \
- err = -ENOMEM; \
- } \
- err; \
- })
+ long err = 0; \
+ if (unlikely(uffd_wp_protect_file(vma, cp_flags))) { \
+ low##_t *p = low##_alloc(vma->vm_mm, high, addr); \
+ if (p == NULL) \
+ err = -ENOMEM; \
+ } \
+ err; \
+ })
static inline long change_pmd_range(struct mmu_gather *tlb,
struct vm_area_struct *vma, pud_t *pud, unsigned long addr,
_
Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
mm-memfd-add-mfd_noexec_seal-and-mfd_exec-fix.patch
mm-memfd-add-mfd_noexec_seal-and-mfd_exec-fix-fix.patch
mm-memfd-add-mfd_noexec_seal-and-mfd_exec-fix-3.patch
mm-memfd-add-mfd_noexec_seal-and-mfd_exec-fix-3-fix.patch
mm-hugetlb-introduce-hugetlb_walk-checkpatch-fixes.patch
mm-memcontrol-deprecate-charge-moving-fix.patch
mm-swap-convert-deactivate_page-to-folio_deactivate-fix.patch
mm-uffd-detect-pgtable-allocation-failures-checkpatch-fixes.patch
error-injection-remove-ei_etype_none-fix.patch
hfsplus-remove-unnecessary-variable-initialization-fix.patch
