The patch titled Subject: maple_tree: refine ma_state init from mas_start() has been added to the -mm mm-unstable branch. Its filename is maple_tree-refine-ma_state-init-from-mas_start.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/maple_tree-refine-ma_state-init-from-mas_start.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Vernon Yang <vernon2gm@xxxxxxxxx> Subject: maple_tree: refine ma_state init from mas_start() Date: Wed, 21 Dec 2022 14:00:57 +0800 If mas->node is an MAS_START, there are three cases, and they all assign different values to mas->node and mas->offset. So there is no need to set them to a default value before updating. Update them directly to make them easier to understand and for better readability. Link: https://lkml.kernel.org/r/20221221060058.609003-7-vernon2gm@xxxxxxxxx Signed-off-by: Vernon Yang <vernon2gm@xxxxxxxxx> Reviewed-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- lib/maple_tree.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/lib/maple_tree.c~maple_tree-refine-ma_state-init-from-mas_start +++ a/lib/maple_tree.c @@ -1329,7 +1329,7 @@ static void mas_node_count(struct ma_sta * mas_start() - Sets up maple state for operations. * @mas: The maple state. * - * If mas->node == MAS_START, then set the min, max, depth, and offset to + * If mas->node == MAS_START, then set the min, max and depth to * defaults. * * Return: @@ -1343,22 +1343,22 @@ static inline struct maple_enode *mas_st if (likely(mas_is_start(mas))) { struct maple_enode *root; - mas->node = MAS_NONE; mas->min = 0; mas->max = ULONG_MAX; mas->depth = 0; - mas->offset = 0; root = mas_root(mas); /* Tree with nodes */ if (likely(xa_is_node(root))) { mas->depth = 1; mas->node = mte_safe_root(root); + mas->offset = 0; return NULL; } /* empty tree */ if (unlikely(!root)) { + mas->node = MAS_NONE; mas->offset = MAPLE_NODE_SLOTS; return NULL; } _ Patches currently in -mm which might be from vernon2gm@xxxxxxxxx are maple_tree-remove-extra-space-and-blank-line.patch maple_tree-remove-extra-return-statement.patch maple_tree-use-mt_node_max-instead-of-direct-operations-mt_max.patch maple_tree-use-macro-ma_root_parent-instead-of-number.patch maple_tree-remove-the-redundant-code.patch maple_tree-refine-ma_state-init-from-mas_start.patch maple_tree-refine-mab_calc_split-function.patch