On Wed 23-11-22 11:57:55, Andrew Morton wrote:
[...]
> -static inline void warn_if_node_offline(int nid, gfp_t gfp_mask)
> +static inline void warn_if_node_offline(int this_node, gfp_t gfp_mask)
> {
> - gfp_t gfp = gfp_mask & (__GFP_THISNODE|__GFP_NOWARN);
> + gfp_t warn_gfp = gfp_mask & (__GFP_THISNODE|__GFP_NOWARN);
>
> - if ((gfp == (__GFP_THISNODE|__GFP_NOWARN)) && !node_online(nid)) {
> - pr_warn("%pGg allocation from offline node %d\n", &gfp, nid);
> - dump_stack();
> - }
> + if (warn_gfp != (__GFP_THISNODE|__GFP_NOWARN))
> + return;
> +
> + if(node_online(this_node))
> + return;
> +
> + pr_warn("%pGg allocation from offline node %d\n", &warn_gfp, this_node);
This should be gfp_mask printed, not the filtered part of it.
> + dump_stack();
> }
>
> /*
> _
>
> Patches currently in -mm which might be from shy828301@xxxxxxxxx are
>
> mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode.patch
> mm-replace-vm_warn_on-to-pr_warn-if-the-node-is-offline-with-__gfp_thisnode-v4.patch
--
Michal Hocko
SUSE Labs
