The patch titled
Subject: Re: mm/ksm: convert break_ksm() to use walk_page_range_vma()
has been added to the -mm mm-unstable branch. Its filename is
mm-ksm-convert-break_ksm-to-use-walk_page_range_vma-fix.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-ksm-convert-break_ksm-to-use-walk_page_range_vma-fix.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: David Hildenbrand <david@xxxxxxxxxx>
Subject: Re: mm/ksm: convert break_ksm() to use walk_page_range_vma()
Date: Thu, 20 Oct 2022 10:59:05 +0200
we fail to drop the lock
Link: https://lkml.kernel.org/r/8c86678a-3bfb-3854-b1a9-ae5969e730b8@xxxxxxxxxx
Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/ksm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/mm/ksm.c~mm-ksm-convert-break_ksm-to-use-walk_page_range_vma-fix
+++ a/mm/ksm.c
@@ -449,7 +449,7 @@ int break_ksm_pmd_entry(pmd_t *pmd, unsi
ptent = *pte;
if (pte_none(ptent))
- return 1;
+ goto out_unlock;
if (!pte_present(ptent)) {
swp_entry_t entry = pte_to_swp_entry(ptent);
@@ -465,6 +465,7 @@ int break_ksm_pmd_entry(pmd_t *pmd, unsi
}
if (page && PageKsm(page))
*ksm_page = true;
+out_unlock:
pte_unmap_unlock(pte, ptl);
return 1;
}
_
Patches currently in -mm which might be from david@xxxxxxxxxx are
selftests-vm-add-test-to-measure-madv_unmergeable-performance.patch
mm-ksm-simplify-break_ksm-to-not-rely-on-vm_fault_write.patch
mm-remove-vm_fault_write.patch
mm-ksm-fix-ksm-cow-breaking-with-userfaultfd-wp-via-fault_flag_unshare.patch
mm-pagewalk-add-walk_page_range_vma.patch
mm-ksm-convert-break_ksm-to-use-walk_page_range_vma.patch
mm-ksm-convert-break_ksm-to-use-walk_page_range_vma-fix.patch
mm-gup-remove-foll_migration.patch
selftests-vm-anon_cow-test-cow-handling-of-anonymous-memory.patch
selftests-vm-factor-out-pagemap_is_populated-into-vm_util.patch
selftests-vm-anon_cow-thp-tests.patch
selftests-vm-anon_cow-hugetlb-tests.patch
selftests-vm-anon_cow-add-liburing-test-cases.patch
mm-gup_test-start-stop-read-functionality-for-pin-longterm-test.patch
mm-gup_test-start-stop-read-functionality-for-pin-longterm-test-fix.patch
selftests-vm-anon_cow-add-r-o-longterm-tests-via-gup_test.patch
