The quilt patch titled
Subject: mm/demotion: fix kernel error with memory hotplug
has been removed from the -mm tree. Its filename was
mm-demotion-add-hotplug-callbacks-to-handle-new-numa-node-onlined-fix.patch
This patch was dropped because it was folded into mm-demotion-add-hotplug-callbacks-to-handle-new-numa-node-onlined.patch
------------------------------------------------------
From: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxx>
Subject: mm/demotion: fix kernel error with memory hotplug
Date: Thu, 25 Aug 2022 14:50:19 +0530
On memory hot unplug, the kernel removes the node memory type from the
associated memory tier. Use list_del_init instead of list del such that
the same memory type can be added back to a memory tier on hotplug.
Without this, we get the below warning and return error on
adding memory type to a new memory tier.
[ 33.596095] ------------[ cut here ]------------
[ 33.596099] WARNING: CPU: 3 PID: 667 at mm/memory-tiers.c:115 set_node_memory_tier+0xd6/0x2e0
[ 33.596109] Modules linked in: kmem
...
[ 33.596126] RIP: 0010:set_node_memory_tier+0xd6/0x2e0
....
[ 33.596196] memtier_hotplug_callback+0x48/0x68
[ 33.596204] blocking_notifier_call_chain+0x80/0xc0
[ 33.596211] online_pages+0x25e/0x280
[ 33.596218] memory_block_change_state+0x176/0x1f0
[ 33.596225] memory_subsys_online+0x37/0x40
[ 33.596230] online_store+0x9b/0x130
[ 33.596236] kernfs_fop_write_iter+0x128/0x1b0
[ 33.596242] vfs_write+0x24b/0x2c0
[ 33.596249] ksys_write+0x74/0xe0
[ 33.596254] do_syscall_64+0x43/0x90
[ 33.596259] entry_SYSCALL_64_after_hwframe+0x63/0xcd
Link: https://lkml.kernel.org/r/20220825092019.379069-1-aneesh.kumar@xxxxxxxxxxxxx
Fixes: "mm/demotion: Add hotplug callbacks to handle new numa node onlined"
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxx>
Cc: Alistair Popple <apopple@xxxxxxxxxx>
Cc: Bharata B Rao <bharata@xxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Cc: Dave Hansen <dave.hansen@xxxxxxxxx>
Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx>
Cc: Hesham Almatary <hesham.almatary@xxxxxxxxxx>
Cc: "Huang, Ying" <ying.huang@xxxxxxxxx>
Cc: Jagdish Gediya <jvgediya.oss@xxxxxxxxx>
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxxxx>
Cc: Tim Chen <tim.c.chen@xxxxxxxxx>
Cc: Wei Xu <weixugc@xxxxxxxxxx>
Cc: Yang Shi <shy828301@xxxxxxxxx>
Cc: SeongJae Park <sj@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/memory-tiers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/memory-tiers.c~mm-demotion-add-hotplug-callbacks-to-handle-new-numa-node-onlined-fix
+++ a/mm/memory-tiers.c
@@ -134,7 +134,7 @@ static bool clear_node_memory_tier(int n
memtype = node_memory_types[node];
node_clear(node, memtype->nodes);
if (nodes_empty(memtype->nodes)) {
- list_del(&memtype->tier_sibiling);
+ list_del_init(&memtype->tier_sibiling);
memtype->memtier = NULL;
if (list_empty(&memtier->memory_types))
destroy_memory_tier(memtier);
_
Patches currently in -mm which might be from aneesh.kumar@xxxxxxxxxxxxx are
mm-demotion-add-support-for-explicit-memory-tiers.patch
mm-demotion-move-memory-demotion-related-code.patch
mm-demotion-add-hotplug-callbacks-to-handle-new-numa-node-onlined.patch
mm-demotion-dax-kmem-set-nodes-abstract-distance-to-memtier_default_dax_adistance.patch
mm-demotion-dax-kmem-set-nodes-abstract-distance-to-memtier_default_dax_adistance-fix.patch
mm-demotion-build-demotion-targets-based-on-explicit-memory-tiers.patch
mm-demotion-add-pg_data_t-member-to-track-node-memory-tier-details.patch
mm-demotion-drop-memtier-from-memtype.patch
mm-demotion-update-node_is_toptier-to-work-with-memory-tiers.patch
mm-demotion-update-node_is_toptier-to-work-with-memory-tiers-fix-3.patch
lib-nodemask-optimize-node_random-for-nodemask-with-single-numa-node.patch
mm-demotion-expose-memory-tier-details-via-sysfs.patch
mm-demotion-expose-memory-tier-details-via-sysfs-v4.patch
