The patch titled
Subject: damon/sysfs: Fix possible memleak on damon_sysfs_add_target.
has been added to the -mm mm-unstable branch. Its filename is
damon-sysfs-fix-possible-memleak-on-damon_sysfs_add_target.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/damon-sysfs-fix-possible-memleak-on-damon_sysfs_add_target.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Levi Yun <ppbuk5246@xxxxxxxxx>
Subject: damon/sysfs: Fix possible memleak on damon_sysfs_add_target.
Date: Sun, 25 Sep 2022 23:02:57 +0900
When damon_sysfs_add_target couldn't find proper task, New allocated
damon_target structure isn't registered yet, So, it's impossible to free
new allocated one by damon_sysfs_destroy_targets.
By calling additional damon_free_target when find_get_pid function, Fix
possible memory leak.
Link: https://lkml.kernel.org/r/20220925140257.23431-1-ppbuk5246@xxxxxxxxx
Signed-off-by: Levi Yun <ppbuk5246@xxxxxxxxx>
Cc: SeongJae Park <sj@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
--- a/mm/damon/sysfs.c~damon-sysfs-fix-possible-memleak-on-damon_sysfs_add_target
+++ a/mm/damon/sysfs.c
@@ -2174,8 +2174,11 @@ static int damon_sysfs_add_target(struct
return -ENOMEM;
if (damon_target_has_pid(ctx)) {
t->pid = find_get_pid(sys_target->pid);
- if (!t->pid)
+ if (!t->pid) {
+ damon_free_target(t);
+
goto destroy_targets_out;
+ }
}
damon_add_target(ctx, t);
err = damon_sysfs_set_regions(t, sys_target->regions);
_
Patches currently in -mm which might be from ppbuk5246@xxxxxxxxx are
damon-sysfs-fix-possible-memleak-on-damon_sysfs_add_target.patch
