The patch titled Subject: relay: use kvcalloc to alloc page array in relay_alloc_page_array has been added to the -mm mm-nonmm-unstable branch. Its filename is relay-use-kvcalloc-to-alloc-page-array-in-relay_alloc_page_array.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/relay-use-kvcalloc-to-alloc-page-array-in-relay_alloc_page_array.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: wuchi <wuchi.zero@xxxxxxxxx> Subject: relay: use kvcalloc to alloc page array in relay_alloc_page_array Date: Fri, 9 Sep 2022 18:10:25 +0800 kvcalloc() is safer because it will check the integer overflows, and using it will simple the logic of allocation size. Link: https://lkml.kernel.org/r/20220909101025.82955-1-wuchi.zero@xxxxxxxxx Signed-off-by: wuchi <wuchi.zero@xxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxx> Cc: Jens Axboe <axboe@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- kernel/relay.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/kernel/relay.c~relay-use-kvcalloc-to-alloc-page-array-in-relay_alloc_page_array +++ a/kernel/relay.c @@ -60,10 +60,7 @@ static const struct vm_operations_struct */ static struct page **relay_alloc_page_array(unsigned int n_pages) { - const size_t pa_size = n_pages * sizeof(struct page *); - if (pa_size > PAGE_SIZE) - return vzalloc(pa_size); - return kzalloc(pa_size, GFP_KERNEL); + return kvcalloc(n_pages, sizeof(struct page *), GFP_KERNEL); } /* _ Patches currently in -mm which might be from wuchi.zero@xxxxxxxxx are lib-debugobjects-fix-stat-count-and-optimize-debug_objects_mem_init.patch initramfs-mask-my_inptr-as-__initdata.patch profile-simplify-redundant-code-in-profile_setup.patch latencytop-use-the-last-element-of-latency_record-of-system.patch relay-use-kvcalloc-to-alloc-page-array-in-relay_alloc_page_array.patch