On 9/9/22 09:42, David Hildenbrand wrote: ... >>> + if (pages) >>> + goto retry; >>> + else >>> + goto next_page; >>> case -EBUSY: >>> case -EAGAIN: >>> ret = 0; >> >> Will this mess up the refcounts already? afaict follow_page_mask() is the >> only place to grab the pages, and GUP should need to take refcounts on >> pages even without pages** being passed in. >> My mistake for overlooking that super-important point, in review! thanks, -- John Hubbard NVIDIA
