The patch titled Subject: udf: replace ll_rw_block() has been added to the -mm mm-unstable branch. Its filename is udf-replace-ll_rw_block.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/udf-replace-ll_rw_block.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Zhang Yi <yi.zhang@xxxxxxxxxx> Subject: udf: replace ll_rw_block() Date: Thu, 1 Sep 2022 21:35:01 +0800 ll_rw_block() is not safe for the sync read path because it cannot guarantee that submitting read IO if the buffer has been locked. We could get false positive EIO after wait_on_buffer() if the buffer has been locked by others. So stop using ll_rw_block(). We also switch to new bh_readahead_batch() helper for the buffer array readahead path. Link: https://lkml.kernel.org/r/20220901133505.2510834-11-yi.zhang@xxxxxxxxxx Signed-off-by: Zhang Yi <yi.zhang@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/udf/dir.c | 2 +- fs/udf/directory.c | 2 +- fs/udf/inode.c | 8 +------- 3 files changed, 3 insertions(+), 9 deletions(-) --- a/fs/udf/dir.c~udf-replace-ll_rw_block +++ a/fs/udf/dir.c @@ -130,7 +130,7 @@ static int udf_readdir(struct file *file brelse(tmp); } if (num) { - ll_rw_block(REQ_OP_READ | REQ_RAHEAD, num, bha); + bh_readahead_batch(num, bha, REQ_RAHEAD); for (i = 0; i < num; i++) brelse(bha[i]); } --- a/fs/udf/directory.c~udf-replace-ll_rw_block +++ a/fs/udf/directory.c @@ -89,7 +89,7 @@ struct fileIdentDesc *udf_fileident_read brelse(tmp); } if (num) { - ll_rw_block(REQ_OP_READ | REQ_RAHEAD, num, bha); + bh_readahead_batch(num, bha, REQ_RAHEAD); for (i = 0; i < num; i++) brelse(bha[i]); } --- a/fs/udf/inode.c~udf-replace-ll_rw_block +++ a/fs/udf/inode.c @@ -1211,13 +1211,7 @@ struct buffer_head *udf_bread(struct ino if (!bh) return NULL; - if (buffer_uptodate(bh)) - return bh; - - ll_rw_block(REQ_OP_READ, 1, &bh); - - wait_on_buffer(bh); - if (buffer_uptodate(bh)) + if (bh_read(bh, 0) >= 0) return bh; brelse(bh); _ Patches currently in -mm which might be from yi.zhang@xxxxxxxxxx are fs-buffer-remove-__breadahead_gfp.patch fs-buffer-add-some-new-buffer-read-helpers.patch fs-buffer-replace-ll_rw_block.patch gfs2-replace-ll_rw_block.patch isofs-replace-ll_rw_block.patch jbd2-replace-ll_rw_block.patch ntfs3-replace-ll_rw_block.patch ocfs2-replace-ll_rw_block.patch reiserfs-replace-ll_rw_block.patch udf-replace-ll_rw_block.patch ufs-replace-ll_rw_block.patch fs-buffer-remove-ll_rw_block-helper.patch ext2-replace-bh_submit_read-helper-with-bh_read_locked.patch fs-buffer-remove-bh_submit_read-helper.patch