The patch titled
Subject: mm/gup.c: Fix uninitialized return value on __gup_longterm_locked()
has been added to the -mm mm-unstable branch. Its filename is
mm-gupc-simplify-and-fix-check_and_migrate_movable_pages-return-codes-fix-fix-fix.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-gupc-simplify-and-fix-check_and_migrate_movable_pages-return-codes-fix-fix-fix.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Shigeru Yoshida <yshigeru@xxxxxxxxx>
Subject: mm/gup.c: Fix uninitialized return value on __gup_longterm_locked()
Date: Sun, 28 Aug 2022 08:00:37 +0900
In __gup_longterm_locked(), it returns uninitialized value if
__get_user_pages_locked() fails on the first iteration of the loop since
rc is not initialized.
This patch fixes this issue by properly returning error code if
__get_user_pages_locked() fails.
Link: https://lkml.kernel.org/r/20220827230037.78876-1-syoshida@xxxxxxxxxx
Fixes: 11147539df44 ("mm/gup.c: Fix return value for __gup_longterm_locked()")
Signed-off-by: Shigeru Yoshida <yshigeru@xxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Cc: Alistair Popple <apopple@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/gup.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/mm/gup.c~mm-gupc-simplify-and-fix-check_and_migrate_movable_pages-return-codes-fix-fix-fix
+++ a/mm/gup.c
@@ -2078,8 +2078,10 @@ static long __gup_longterm_locked(struct
nr_pinned_pages = __get_user_pages_locked(mm, start, nr_pages,
pages, vmas, NULL,
gup_flags);
- if (nr_pinned_pages <= 0)
+ if (nr_pinned_pages <= 0) {
+ rc = nr_pinned_pages;
break;
+ }
rc = check_and_migrate_movable_pages(nr_pinned_pages, pages,
gup_flags);
} while (rc == -EAGAIN);
_
Patches currently in -mm which might be from yshigeru@xxxxxxxxx are
mm-gupc-simplify-and-fix-check_and_migrate_movable_pages-return-codes-fix-fix-fix.patch
