The patch titled Subject: mm: pagewalk: fix documentation of PTE hole handling has been added to the -mm mm-unstable branch. Its filename is mm-pagewalk-fix-documentation-of-pte-hole-handling.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-pagewalk-fix-documentation-of-pte-hole-handling.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Rolf Eike Beer <eb@xxxxxxxxx> Subject: mm: pagewalk: fix documentation of PTE hole handling Date: Mon, 22 Aug 2022 15:01:32 +0200 Empty PTEs are passed to the pte_entry callback, not to pte_hole. Link: https://lkml.kernel.org/r/3695521.kQq0lBPeGt@devpool047 Signed-off-by: Rolf Eike Beer <eb@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- include/linux/pagewalk.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/include/linux/pagewalk.h~mm-pagewalk-fix-documentation-of-pte-hole-handling +++ a/include/linux/pagewalk.h @@ -15,12 +15,12 @@ struct mm_walk; * this handler is required to be able to handle * pmd_trans_huge() pmds. They may simply choose to * split_huge_page() instead of handling it explicitly. - * @pte_entry: if set, called for each non-empty PTE (lowest-level) - * entry + * @pte_entry: if set, called for each PTE (lowest-level) entry, + * including empty ones * @pte_hole: if set, called for each hole at all levels, - * depth is -1 if not known, 0:PGD, 1:P4D, 2:PUD, 3:PMD - * 4:PTE. Any folded depths (where PTRS_PER_P?D is equal - * to 1) are skipped. + * depth is -1 if not known, 0:PGD, 1:P4D, 2:PUD, 3:PMD. + * Any folded depths (where PTRS_PER_P?D is equal to 1) + * are skipped. * @hugetlb_entry: if set, called for each hugetlb entry * @test_walk: caller specific callback function to determine whether * we walk over the current vma or not. Returning 0 means _ Patches currently in -mm which might be from eb@xxxxxxxxx are mm-pagewalk-make-error-checks-more-obvious.patch mm-pagewalk-dont-check-vma-in-walk_page_range_novma.patch mm-pagewalk-fix-documentation-of-pte-hole-handling.patch mm-pagewalk-add-api-documentation-for-walk_page_range_novma.patch mm-pagewalk-allow-walk_page_range_novma-without-mm.patch mm-pagewalk-move-variables-to-more-local-scope-tweak-loops.patch