Re: + zsmalloc-remove-unnecessary-size_class-null-check.patch added to mm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On (22/08/11 14:22), Andrew Morton wrote:
> pool->size_class array elements can't be NULL, so this check
> is not needed.
> 
> In the whole code, we assign pool->size_class[i] values that are
> not NULL. Releasing memory for these values occurs in the
> zs_destroy_pool() function, which also releases and destroys the pool.
> 
> In addition, in the zs_stats_size_show() and async_free_zspage(),
> with similar iterations over the array, we don't check it for NULL
> pointer.
> 
> Link: https://lkml.kernel.org/r/20220811153755.16102-3-avromanov@xxxxxxxxxxxxxx
> Signed-off-by: Alexey Romanov <avromanov@xxxxxxxxxxxxxx>
> Cc: Minchan Kim <minchan@xxxxxxxxxx>
> Cc: Nitin Gupta <ngupta@xxxxxxxxxx>
> Cc: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>



[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux