The patch titled Subject: highmem: delete a sentence from kmap_local_page() kdocs has been added to the -mm mm-unstable branch. Its filename is highmem-delete-a-sentence-from-kmap_local_page-kdocs.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/highmem-delete-a-sentence-from-kmap_local_page-kdocs.patch This patch will later appear in the mm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: "Fabio M. De Francesco" <fmdefrancesco@xxxxxxxxx> Subject: highmem: delete a sentence from kmap_local_page() kdocs Date: Thu, 28 Jul 2022 17:48:43 +0200 kmap_local_page() should always be preferred in place of kmap() and kmap_atomic(). "Only use when really necessary." is not consistent with the Documentation/mm/highmem.rst and these kdocs it embeds. Therefore, delete the above-mentioned sentence from kdocs. Link: https://lkml.kernel.org/r/20220728154844.10874-7-fmdefrancesco@xxxxxxxxx Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> Suggested-by: Ira Weiny <ira.weiny@xxxxxxxxx> Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx> Cc: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> Cc: Mike Rapoport <rppt@xxxxxxxxxxxxx> Cc: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> Cc: Catalin Marinas <catalin.marinas@xxxxxxx> Cc: Jonathan Corbet <corbet@xxxxxxx> Cc: Peter Collingbourne <pcc@xxxxxxxxxx> Cc: Vlastimil Babka <vbabka@xxxxxxx> Cc: Will Deacon <will@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- include/linux/highmem.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/include/linux/highmem.h~highmem-delete-a-sentence-from-kmap_local_page-kdocs +++ a/include/linux/highmem.h @@ -86,8 +86,7 @@ static inline void kmap_flush_unused(voi * temporarily mapped. * * While it is significantly faster than kmap() for the higmem case it - * comes with restrictions about the pointer validity. Only use when really - * necessary. + * comes with restrictions about the pointer validity. * * On HIGHMEM enabled systems mapping a highmem page has the side effect of * disabling migration in order to keep the virtual address stable across _ Patches currently in -mm which might be from fmdefrancesco@xxxxxxxxx are highmem-remove-unneeded-spaces-in-kmap_local_page-kdocs.patch highmem-specify-that-kmap_local_page-is-callable-from-interrupts.patch documentation-mm-dont-kmap-pages-which-cant-come-from-highmem.patch documentation-mm-avoid-invalid-use-of-addresses-from-kmap_local_page.patch documentation-mm-prefer-kmap_local_page-and-avoid-kmap.patch highmem-delete-a-sentence-from-kmap_local_page-kdocs.patch documentation-mm-add-details-about-kmap_local_page-and-preemption.patch