Re: + lockdep-make-prove_raw_lock_nesting-depend-on-preempt_rt.patch added to mm-nonmm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-06-16 12:41:27 [-0700], Andrew Morton wrote:
> ------------------------------------------------------
> From: Chen Jun <chenjun102@xxxxxxxxxx>
> Subject: lockdep: make PROVE_RAW_LOCK_NESTING depend on PREEMPT_RT
> Date: Thu, 16 Jun 2022 02:29:11 +0000
> 
> CONFIG_PROVE_RAW_LOCK_NESTING is used to check two things.
> 1. calling spin_lock in hardirq.
> 2. raw_spinlock - spinlock nesting.
> The error messages like below:
> [   13.485711] [ BUG: Invalid wait context ]
> 
> However there is no problem on non-PREEMPT_RT kernel. The messages may be
> confusing and disturbing.
> 
> Therefore, do not check raw_spinlock - spinlock nesting
> on non-PREEMPT_RT kernel.

This is not correct. The annotation is used to detect problems on
non-PREEMPT_RT kernels which occur on PREEMPT_RT. This is documented in
Kconfig. Letting this option depend on PREEMPT_RT renders it pointless
because warning are spit on PREEMPT_RT even without that option enabled.

Please drop that patch.

> Link: https://lkml.kernel.org/r/20220616022911.35826-1-chenjun102@xxxxxxxxxx
> Signed-off-by: Chen Jun <chenjun102@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Sebastian



[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux