Re: + xarray-replace-kernelh-with-the-necessary-inclusions.patch added to mm-nonmm-unstable branch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 08, 2022 at 11:59:32AM -0700, Andrew Morton wrote:
> On Wed, 8 Jun 2022 19:21:05 +0100 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
> 
> > > Perhaps some magic happened with cpp's recognition of include guards?
> > 
> > I had some time to look at this now.  It's picking up
> > /usr/include/linux/limits.h on my machine which is provided by
> > linux-libc-dev.  That's a rather different set of constants from the ones
> > the kernel provides internally, which might cause problems later.  But I'm
> > not in a mood to go poking around the different locations that different
> > environments provide things in, so I think this patch is OK.
> 
> Thanks.
> 
> I don't think it's good to be replacing our limits.h with some random
> system-provided one.  I'll drop the patch.

It's fine. Perhaps we will add a limits.h to the tools. I have to remember this
somewhere.

Thanks, Matthew, for the investigation and finding a root cause.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux