The patch titled
Subject: fat: remove time truncations in vfat_create/vfat_mkdir
has been added to the -mm mm-nonmm-unstable branch. Its filename is
fat-remove-time-truncations-in-vfat_create-vfat_mkdir.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/fat-remove-time-truncations-in-vfat_create-vfat_mkdir.patch
This patch will later appear in the mm-nonmm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Chung-Chiang Cheng <cccheng@xxxxxxxxxxxx>
Subject: fat: remove time truncations in vfat_create/vfat_mkdir
Date: Tue, 3 May 2022 23:25:36 +0800
All the timestamps in vfat_create() and vfat_mkdir() come from
fat_time_fat2unix() which ensures time granularity. We don't need to
truncate them to fit FAT's format.
Moreover, fat_truncate_crtime() and fat_timespec64_trunc_10ms() are also
removed because there is no caller anymore.
Link: https://lkml.kernel.org/r/20220503152536.2503003-4-cccheng@xxxxxxxxxxxx
Signed-off-by: Chung-Chiang Cheng <cccheng@xxxxxxxxxxxx>
Acked-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/fat/fat.h | 2 --
fs/fat/misc.c | 21 ---------------------
fs/fat/namei_vfat.c | 4 ----
3 files changed, 27 deletions(-)
--- a/fs/fat/fat.h~fat-remove-time-truncations-in-vfat_create-vfat_mkdir
+++ a/fs/fat/fat.h
@@ -456,8 +456,6 @@ extern void fat_time_unix2fat(struct msd
__le16 *time, __le16 *date, u8 *time_cs);
extern struct timespec64 fat_truncate_atime(const struct msdos_sb_info *sbi,
const struct timespec64 *ts);
-extern struct timespec64 fat_truncate_crtime(const struct msdos_sb_info *sbi,
- const struct timespec64 *ts);
extern struct timespec64 fat_truncate_mtime(const struct msdos_sb_info *sbi,
const struct timespec64 *ts);
extern int fat_truncate_time(struct inode *inode, struct timespec64 *now,
--- a/fs/fat/misc.c~fat-remove-time-truncations-in-vfat_create-vfat_mkdir
+++ a/fs/fat/misc.c
@@ -281,13 +281,6 @@ static inline struct timespec64 fat_time
return (struct timespec64){ ts.tv_sec & ~1ULL, 0 };
}
-static inline struct timespec64 fat_timespec64_trunc_10ms(struct timespec64 ts)
-{
- if (ts.tv_nsec)
- ts.tv_nsec -= ts.tv_nsec % 10000000UL;
- return ts;
-}
-
/*
* truncate atime to 24 hour granularity (00:00:00 in local timezone)
*/
@@ -306,20 +299,6 @@ struct timespec64 fat_truncate_atime(con
}
/*
- * truncate creation time with appropriate granularity:
- * msdos - 2 seconds
- * vfat - 10 milliseconds
- */
-struct timespec64 fat_truncate_crtime(const struct msdos_sb_info *sbi,
- const struct timespec64 *ts)
-{
- if (sbi->options.isvfat)
- return fat_timespec64_trunc_10ms(*ts);
- else
- return fat_timespec64_trunc_2secs(*ts);
-}
-
-/*
* truncate mtime to 2 second granularity
*/
struct timespec64 fat_truncate_mtime(const struct msdos_sb_info *sbi,
--- a/fs/fat/namei_vfat.c~fat-remove-time-truncations-in-vfat_create-vfat_mkdir
+++ a/fs/fat/namei_vfat.c
@@ -780,8 +780,6 @@ static int vfat_create(struct user_names
goto out;
}
inode_inc_iversion(inode);
- fat_truncate_time(inode, &ts, S_ATIME|S_CTIME|S_MTIME);
- /* timestamp is already written, so mark_inode_dirty() is unneeded. */
d_instantiate(dentry, inode);
out:
@@ -878,8 +876,6 @@ static int vfat_mkdir(struct user_namesp
}
inode_inc_iversion(inode);
set_nlink(inode, 2);
- fat_truncate_time(inode, &ts, S_ATIME|S_CTIME|S_MTIME);
- /* timestamp is already written, so mark_inode_dirty() is unneeded. */
d_instantiate(dentry, inode);
_
Patches currently in -mm which might be from cccheng@xxxxxxxxxxxx are
fat-split-fat_truncate_time-into-separate-functions.patch
fat-ignore-ctime-updates-and-keep-ctime-identical-to-mtime-in-memory.patch
fat-report-creation-time-in-statx.patch
fat-remove-time-truncations-in-vfat_create-vfat_mkdir.patch
