On Fri, 13 May 2022 02:17:10 +0100 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > On Thu, May 12, 2022 at 06:05:42PM -0700, Andrew Morton wrote: > > { > > - if (kstrtobool(buf, &numa_demotion_enabled)) > > - return -EINVAL; > > + ssize_t ret; > > + > > + ret = kstrtobool(buf, &numa_demotion_enabled); > > + return ret; > > Umm ... missing if? doh, thanks.