On martedì 10 maggio 2022 06:15:28 CEST Andrew Morton wrote: > > The quilt patch titled > Subject: mm/highmem: VM_BUG_ON() if offset + len > PAGE_SIZE > has been removed from the -mm tree. Its filename was > mm-highmem-vm_bug_on-if-offset-len-page_size.patch > > This patch was dropped because it was merged into mm-stable > > ------------------------------------------------------ > From: "Fabio M. De Francesco" <fmdefrancesco@xxxxxxxxx> > Subject: mm/highmem: VM_BUG_ON() if offset + len > PAGE_SIZE > > Add VM_BUG_ON() bounds checking to make sure that, if "offset + len> > PAGE_SIZE", memset() does not corrupt data in adjacent pages. > > Mainly to match all the similar functions in highmem.h. > > Link: https://lkml.kernel.org/r/20220426193020.8710-1-fmdefrancesco@xxxxxxxxx > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> > Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Ira Weiny <ira.weiny@xxxxxxxxx> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx> > Cc: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> > Cc: Peter Collingbourne <pcc@xxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > > include/linux/highmem.h | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/include/linux/highmem.h~mm-highmem-vm_bug_on-if-offset-len- page_size > +++ a/include/linux/highmem.h > @@ -358,6 +358,8 @@ static inline void memcpy_to_page(struct > static inline void memzero_page(struct page *page, size_t offset, size_t len) > { > char *addr = kmap_local_page(page); > + > + VM_BUG_ON(offset + len > PAGE_SIZE); > memset(addr + offset, 0, len); > flush_dcache_page(page); > kunmap_local(addr); > _ > > Patches currently in -mm which might be from fmdefrancesco@xxxxxxxxx are > > > Hello Andrew, I still see that the list of my patches currently in -mm is empty. On April 28th I sent v4 of a series.[1] It received two "Reviewed-by" tags, respectively from Ira Weiny[2] and Sebastian Andrzej Siewior.[3] Therefore, I assume that the v4 of the series can be considered final. Can you please take a look at it and either apply to -mm or let me know if there is anything which should still be improved? Thank you very much, Fabio M. De Francesco [1] [PATCH v4 0/4] Extend and reorganize Highmem's documentation https://lore.kernel.org/lkml/20220428212455.892-1-fmdefrancesco@xxxxxxxxx/ https://lore.kernel.org/lkml/20220428212455.892-2-fmdefrancesco@xxxxxxxxx/ https://lore.kernel.org/lkml/20220428212455.892-3-fmdefrancesco@xxxxxxxxx/ https://lore.kernel.org/lkml/20220428212455.892-4-fmdefrancesco@xxxxxxxxx/ https://lore.kernel.org/lkml/20220428212455.892-5-fmdefrancesco@xxxxxxxxx/ [2] Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx> (for the series) https://lore.kernel.org/lkml/Ym4WSstEQI7yYU0n@iweiny-server/ [3] Reviewed-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> (for the series) [3] https://lore.kernel.org/lkml/YmuK79YPRAi0fHhH@xxxxxxxxxxxxx/
