On Wed, 27 Apr 2022 14:41:30 +0800 Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote: > On 2022/4/27 14:25, Andrew Morton wrote: > > > > The patch titled > > Subject: mm/vmscan: activate swap-backed executable folios after first usage > > has been removed from the -mm tree. Its filename was > > mm-vmscan-activate-swap-backed-executable-folios-after-first-usage.patch > > > > This patch was dropped because it was nacked > > Hi Andrew, > > Since this patch is nacked, should I resend the whole series with this patch dropped? > And I'd like to change this patch to use the helper folio_is_file_lru too, something like below: > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index ed484a0e9cd0..60ccbebec4c8 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1412,9 +1412,9 @@ static enum page_references folio_check_references(struct folio *folio, > return PAGEREF_ACTIVATE; > > /* > - * Activate executable folios after first usage. > + * Activate file-backed executable folios after first usage. > */ > - if (vm_flags & VM_EXEC) > + if ((vm_flags & VM_EXEC) && folio_is_file_lru(folio)) > return PAGEREF_ACTIVATE; > > return PAGEREF_KEEP; > > Should I send this patch separately or resend the whole series with this new change attached? > I dropped this patch individually, so there's no need to resend the others.
