The patch titled Subject: ipc/sem: Remove redundant assignments has been added to the -mm tree. Its filename is ipc-sem-remove-redundant-assignments.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/ipc-sem-remove-redundant-assignments.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/ipc-sem-remove-redundant-assignments.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Michal Orzel <michalorzel.eng@xxxxxxxxx> Subject: ipc/sem: Remove redundant assignments Get rid of redundant assignments which end up in values not being read either because they are overwritten or the function ends. Reported by clang-tidy [deadcode.DeadStores] Link: https://lkml.kernel.org/r/20220409101933.207157-1-michalorzel.eng@xxxxxxxxx Signed-off-by: Michal Orzel <michalorzel.eng@xxxxxxxxx> Reviewed-by: Tom Rix <trix@xxxxxxxxxx> Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx> Cc: Nick Desaulniers <ndesaulniers@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- --- a/ipc/sem.c~ipc-sem-remove-redundant-assignments +++ a/ipc/sem.c @@ -766,7 +766,6 @@ static int perform_atomic_semop(struct s for (sop = sops; sop < sops + nsops; sop++) { curr = &sma->sems[sop->sem_num]; sem_op = sop->sem_op; - result = curr->semval; if (sop->sem_flg & SEM_UNDO) { int undo = un->semadj[sop->sem_num] - sem_op; @@ -1430,7 +1429,6 @@ static int semctl_main(struct ipc_namesp if (err) goto out_rcu_wakeup; - err = -EACCES; switch (cmd) { case GETALL: { _ Patches currently in -mm which might be from michalorzel.eng@xxxxxxxxx are kexec-remove-redundant-assignments.patch ipc-sem-remove-redundant-assignments.patch