The patch titled
Subject: mm/khugepaged: sched to numa node when collapse huge page
has been added to the -mm tree. Its filename is
mm-khugepaged-sched-to-numa-node-when-collapse-huge-page.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-khugepaged-sched-to-numa-node-when-collapse-huge-page.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-khugepaged-sched-to-numa-node-when-collapse-huge-page.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Bibo Mao <maobibo@xxxxxxxxxxx>
Subject: mm/khugepaged: sched to numa node when collapse huge page
Collapsing a huge page will copy huge page from general small pages, dest
node is calculated from most one of source pages, however THP daemon is
not scheduled on dest node. The performance may be poor since huge page
copying across nodes, also cache is not used for target node. With this
patch, khugepaged daemon switches to the same numa node with huge page.
It saves copying time and makes use of local cache better.
With this patch, specint 2006 base performance is improved with 6% on
Loongson 3C5000L platform with 32 cores and 8 numa nodes.
Link: https://lkml.kernel.org/r/20220317065024.2635069-1-maobibo@xxxxxxxxxxx
Signed-off-by: Bibo Mao <maobibo@xxxxxxxxxxx>
Cc: David Hildenbrand <david@xxxxxxxxxx>
Cc: Yang Shi <shy828301@xxxxxxxxx>
Cc: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/khugepaged.c | 8 ++++++++
1 file changed, 8 insertions(+)
--- a/mm/khugepaged.c~mm-khugepaged-sched-to-numa-node-when-collapse-huge-page
+++ a/mm/khugepaged.c
@@ -1055,6 +1055,7 @@ static void collapse_huge_page(struct mm
struct vm_area_struct *vma;
struct mmu_notifier_range range;
gfp_t gfp;
+ const struct cpumask *cpumask;
VM_BUG_ON(address & ~HPAGE_PMD_MASK);
@@ -1068,6 +1069,13 @@ static void collapse_huge_page(struct mm
* that. We will recheck the vma after taking it again in write mode.
*/
mmap_read_unlock(mm);
+
+ /* sched to specified node before huage page memory copy */
+ if (task_node(current) != node) {
+ cpumask = cpumask_of_node(node);
+ if (!cpumask_empty(cpumask))
+ set_cpus_allowed_ptr(current, cpumask);
+ }
new_page = khugepaged_alloc_page(hpage, gfp, node);
if (!new_page) {
result = SCAN_ALLOC_HUGE_PAGE_FAIL;
_
Patches currently in -mm which might be from maobibo@xxxxxxxxxxx are
mm-khugepaged-sched-to-numa-node-when-collapse-huge-page.patch
