The patch titled
Subject: mm/damon/sysfs: fix missing error code in damon_sysfs_attrs_add_dirs()
has been added to the -mm tree. Its filename is
mm-damon-implement-a-minimal-stub-for-sysfs-based-damon-interface-fix.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-damon-implement-a-minimal-stub-for-sysfs-based-damon-interface-fix.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-damon-implement-a-minimal-stub-for-sysfs-based-damon-interface-fix.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
Subject: mm/damon/sysfs: fix missing error code in damon_sysfs_attrs_add_dirs()
The error code is missing in this code scenario, add the error code
'-ENOMEM' to the return value 'err'.
Eliminate the follow smatch warning:
mm/damon/sysfs.c:1647 damon_sysfs_attrs_add_dirs() warn: missing error
code 'err'.
Link: https://lkml.kernel.org/r/20220302111120.24984-1-jiapeng.chong@xxxxxxxxxxxxxxxxx
Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/damon/sysfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/mm/damon/sysfs.c~mm-damon-implement-a-minimal-stub-for-sysfs-based-damon-interface-fix
+++ a/mm/damon/sysfs.c
@@ -452,8 +452,10 @@ static int damon_sysfs_attrs_add_dirs(st
attrs->intervals = intervals;
nr_regions_range = damon_sysfs_ul_range_alloc(10, 1000);
- if (!nr_regions_range)
+ if (!nr_regions_range) {
+ err = -ENOMEM;
goto put_intervals_out;
+ }
err = kobject_init_and_add(&nr_regions_range->kobj,
&damon_sysfs_ul_range_ktype, &attrs->kobj,
_
Patches currently in -mm which might be from jiapeng.chong@xxxxxxxxxxxxxxxxx are
mm-vmallocc-fix-unused-function-warning.patch
mm-damon-implement-a-minimal-stub-for-sysfs-based-damon-interface-fix.patch
