The patch titled
Subject: nilfs2: remove redundant pointer sbufs
has been added to the -mm tree. Its filename is
nilfs2-remove-redundant-pointer-sbufs.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/nilfs2-remove-redundant-pointer-sbufs.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/nilfs2-remove-redundant-pointer-sbufs.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Colin Ian King <colin.i.king@xxxxxxxxx>
Subject: nilfs2: remove redundant pointer sbufs
Pointer sbufs is being assigned a value but it's not being used later on.
The pointer is redundant and can be removed. Cleans up scan-build static
analysis warning:
fs/nilfs2/page.c:203:8: warning: Although the value stored to 'sbufs'
is used in the enclosing expression, the value is never actually read
from 'sbufs' [deadcode.DeadStores]
sbh = sbufs = page_buffers(src);
Link: https://lkml.kernel.org/r/20211211180955.550380-1-colin.i.king@xxxxxxxxx
Link: https://lkml.kernel.org/r/1640712476-15136-1-git-send-email-konishi.ryusuke@xxxxxxxxx
Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/nilfs2/page.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/fs/nilfs2/page.c~nilfs2-remove-redundant-pointer-sbufs
+++ a/fs/nilfs2/page.c
@@ -195,12 +195,12 @@ void nilfs_page_bug(struct page *page)
*/
static void nilfs_copy_page(struct page *dst, struct page *src, int copy_dirty)
{
- struct buffer_head *dbh, *dbufs, *sbh, *sbufs;
+ struct buffer_head *dbh, *dbufs, *sbh;
unsigned long mask = NILFS_BUFFER_INHERENT_BITS;
BUG_ON(PageWriteback(dst));
- sbh = sbufs = page_buffers(src);
+ sbh = page_buffers(src);
if (!page_has_buffers(dst))
create_empty_buffers(dst, sbh->b_size, 0);
_
Patches currently in -mm which might be from colin.i.king@xxxxxxxxx are
mm-migrate-remove-redundant-variables-used-in-a-for-loop.patch
nilfs2-remove-redundant-pointer-sbufs.patch
kernel-sysctlc-remove-unused-variable-ten_thousand.patch
