The patch titled Subject: mm/damon/dbgfs: remove an unnecessary variable has been added to the -mm tree. Its filename is mm-damon-dbgfs-remove-a-unnecessary-variable.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/mm-damon-dbgfs-remove-a-unnecessary-variable.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/mm-damon-dbgfs-remove-a-unnecessary-variable.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: SeongJae Park <sj@xxxxxxxxxx> Subject: mm/damon/dbgfs: remove an unnecessary variable Patch series "mm/damon: Hide unnecessary information disclosures". DAMON is exposing some unnecessary information including kernel pointer in kernel log and tracepoint. This patchset hides such information. The first patch is only for a trivial cleanup, though. This patch (of 4): This commit removes a unnecessarily used variable in dbgfs_target_ids_write(). Link: https://lkml.kernel.org/r/20211229131016.23641-1-sj@xxxxxxxxxx Link: https://lkml.kernel.org/r/20211229131016.23641-2-sj@xxxxxxxxxx Fixes: 4bc05954d007 ("mm/damon: implement a debugfs-based user space interface") Signed-off-by: SeongJae Park <sj@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/damon/dbgfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/mm/damon/dbgfs.c~mm-damon-dbgfs-remove-a-unnecessary-variable +++ a/mm/damon/dbgfs.c @@ -363,7 +363,7 @@ static ssize_t dbgfs_target_ids_write(st { struct damon_ctx *ctx = file->private_data; bool id_is_pid = true; - char *kbuf, *nrs; + char *kbuf; unsigned long *targets; ssize_t nr_targets; ssize_t ret; @@ -373,14 +373,13 @@ static ssize_t dbgfs_target_ids_write(st if (IS_ERR(kbuf)) return PTR_ERR(kbuf); - nrs = kbuf; if (!strncmp(kbuf, "paddr\n", count)) { id_is_pid = false; /* target id is meaningless here, but we set it just for fun */ scnprintf(kbuf, count, "42 "); } - targets = str_to_target_ids(nrs, count, &nr_targets); + targets = str_to_target_ids(kbuf, count, &nr_targets); if (!targets) { ret = -ENOMEM; goto out; _ Patches currently in -mm which might be from sj@xxxxxxxxxx are mm-damon-remove-some-no-need-func-definitions-in-damonh-file-fix.patch mm-damon-convert-macro-functions-to-static-inline-functions.patch docs-admin-guide-mm-damon-usage-update-for-scheme-quotas-and-watermarks.patch docs-admin-guide-mm-damon-usage-remove-redundant-information.patch docs-admin-guide-mm-damon-usage-mention-tracepoint-at-the-beginning.patch docs-admin-guide-mm-damon-usage-update-for-kdamond_pid-and-mkrm_contexts.patch mm-damon-remove-a-mistakenly-added-comment-for-a-future-feature.patch mm-damon-schemes-account-scheme-actions-that-successfully-applied.patch mm-damon-schemes-account-how-many-times-quota-limit-has-exceeded.patch mm-damon-reclaim-provide-reclamation-statistics.patch docs-admin-guide-mm-damon-reclaim-document-statistics-parameters.patch mm-damon-dbgfs-support-all-damos-stats.patch docs-admin-guide-mm-damon-usage-update-for-schemes-statistics.patch mm-damon-dbgfs-remove-a-unnecessary-variable.patch mm-damon-vaddr-use-pr_debug-for-damon_va_three_regions-failure-logging.patch mm-damon-vaddr-hide-kernel-pointer-from-damon_va_three_regions-failure-log.patch mm-damon-hide-kernel-pointer-from-tracepoint-event.patch