The patch titled
Subject: mm/migrate: remove redundant variables used in a for-loop
has been added to the -mm tree. Its filename is
mm-migrate-remove-redundant-variables-used-in-a-for-loop.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-migrate-remove-redundant-variables-used-in-a-for-loop.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-migrate-remove-redundant-variables-used-in-a-for-loop.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Colin Ian King <colin.i.king@xxxxxxxxx>
Subject: mm/migrate: remove redundant variables used in a for-loop
The variable addr is being set and incremented in a for-loop but not
actually being used. It is redundant and so addr and also variable start
can be removed.
Link: https://lkml.kernel.org/r/20211221185729.609630-1-colin.i.king@xxxxxxxxx
Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/migrate.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- a/mm/migrate.c~mm-migrate-remove-redundant-variables-used-in-a-for-loop
+++ a/mm/migrate.c
@@ -2451,8 +2451,7 @@ static bool migrate_vma_check_page(struc
static void migrate_vma_unmap(struct migrate_vma *migrate)
{
const unsigned long npages = migrate->npages;
- const unsigned long start = migrate->start;
- unsigned long addr, i, restore = 0;
+ unsigned long i, restore = 0;
bool allow_drain = true;
lru_add_drain();
@@ -2498,7 +2497,7 @@ static void migrate_vma_unmap(struct mig
}
}
- for (addr = start, i = 0; i < npages && restore; addr += PAGE_SIZE, i++) {
+ for (i = 0; i < npages && restore; i++) {
struct page *page = migrate_pfn_to_page(migrate->src[i]);
if (!page || (migrate->src[i] & MIGRATE_PFN_MIGRATE))
_
Patches currently in -mm which might be from colin.i.king@xxxxxxxxx are
mm-migrate-remove-redundant-variables-used-in-a-for-loop.patch
